Skip to content

8349689: Several virtual thread tests missing /native keyword #23550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sendaoYan wants to merge 5 commits into from
Closed

8349689: Several virtual thread tests missing /native keyword #23550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03e76ed
8349689: Several virtual thread tests missing /native keyword
Feb 11, 2025
7c03099
add --enable-native-access=ALL-UNNAMED for test/jdk/java/lang/managem…
Feb 11, 2025
413ee6b
add /native for test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.j…
Feb 11, 2025
07f3435
update copyright year for test/jdk/java/lang/management/ThreadMXBean/…
Feb 11, 2025
912c1ab
Remove the additional check for virtual thread of test/jdk/java/lang/…
Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/jdk/java/lang/Thread/virtual/JfrEvents.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2021, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -27,7 +27,7 @@
* @requires vm.continuations
* @modules jdk.jfr java.base/java.lang:+open jdk.management
* @library /test/lib
* @run junit/othervm --enable-native-access=ALL-UNNAMED JfrEvents
* @run junit/othervm/native --enable-native-access=ALL-UNNAMED JfrEvents
*/

import java.io.IOException;
Expand Down
24 changes: 12 additions & 12 deletions test/jdk/java/lang/Thread/virtual/MonitorEnterExit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2023, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -27,87 +27,87 @@
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xint-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xint -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xint -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xint-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xint -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xint -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xcomp-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xcomp -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xcomp-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xcomp -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xcomp-TieredStopAtLevel1-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xcomp-TieredStopAtLevel1-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xcomp-noTieredCompilation-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:-TieredCompilation -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xcomp -XX:-TieredCompilation -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

/*
* @test id=Xcomp-noTieredCompilation-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:-TieredCompilation -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
* @run junit/othervm/native -Xcomp -XX:-TieredCompilation -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorEnterExit
*/

import java.time.Duration;
Expand Down
24 changes: 12 additions & 12 deletions test/jdk/java/lang/Thread/virtual/MonitorWaitNotify.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2019, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -27,87 +27,87 @@
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xint-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xint -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xint -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xint-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xint -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xint -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xcomp-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xcomp -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xcomp-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xcomp -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xcomp-TieredStopAtLevel1-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xcomp-TieredStopAtLevel1-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xcomp -XX:TieredStopAtLevel=1 -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xcomp-noTieredCompilation-LM_LEGACY
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:-TieredCompilation -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xcomp -XX:-TieredCompilation -XX:LockingMode=1 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

/*
* @test id=Xcomp-noTieredCompilation-LM_LIGHTWEIGHT
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -Xcomp -XX:-TieredCompilation -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
* @run junit/othervm/native -Xcomp -XX:-TieredCompilation -XX:LockingMode=2 --enable-native-access=ALL-UNNAMED MonitorWaitNotify
*/

import java.util.ArrayList;
Expand Down
4 changes: 2 additions & 2 deletions test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -30,7 +30,7 @@
* @modules java.base/java.lang:+open
* @library /test/lib
* @requires vm.opt.LockingMode != 1
* @run main/othervm --enable-native-access=ALL-UNNAMED RetryMonitorEnterWhenPinned
* @run main/othervm/native --enable-native-access=ALL-UNNAMED RetryMonitorEnterWhenPinned
*/

import java.time.Duration;
Expand Down
4 changes: 2 additions & 2 deletions test/jdk/java/lang/Thread/virtual/Starvation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2024, 2025 Oracle and/or its affiliates. All rights reserved.
Copy link
Member

@dholmes-ora dholmes-ora Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the comma after 2025 here. This is now causing failures in our CI.

Copy link
Member Author

@sendaoYan sendaoYan Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I create a new issue JDK-8349876 for that.

* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -25,7 +25,7 @@
* @requires vm.continuations
* @library /test/lib
* @bug 8345294
* @run main/othervm --enable-native-access=ALL-UNNAMED Starvation 100000
* @run main/othervm/timeout=200/native --enable-native-access=ALL-UNNAMED Starvation 100000
*/

import java.time.Duration;
Expand Down
10 changes: 5 additions & 5 deletions test/jdk/java/lang/Thread/virtual/SynchronizedNative.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2023, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -28,31 +28,31 @@
* @requires vm.continuations
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @run junit/othervm --enable-native-access=ALL-UNNAMED SynchronizedNative
* @run junit/othervm/native --enable-native-access=ALL-UNNAMED SynchronizedNative
*/

/*
* @test id=Xint
* @requires vm.continuations
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @run junit/othervm -Xint --enable-native-access=ALL-UNNAMED SynchronizedNative
* @run junit/othervm/native -Xint --enable-native-access=ALL-UNNAMED SynchronizedNative
*/

/*
* @test id=Xcomp-TieredStopAtLevel1
* @requires vm.continuations
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @run junit/othervm -Xcomp -XX:TieredStopAtLevel=1 --enable-native-access=ALL-UNNAMED SynchronizedNative
* @run junit/othervm/native -Xcomp -XX:TieredStopAtLevel=1 --enable-native-access=ALL-UNNAMED SynchronizedNative
*/

/*
* @test id=Xcomp-noTieredCompilation
* @requires vm.continuations
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @run junit/othervm -Xcomp -XX:-TieredCompilation --enable-native-access=ALL-UNNAMED SynchronizedNative
* @run junit/othervm/native -Xcomp -XX:-TieredCompilation --enable-native-access=ALL-UNNAMED SynchronizedNative
*/

import java.util.concurrent.CountDownLatch;
Expand Down
6 changes: 3 additions & 3 deletions test/jdk/java/lang/Thread/virtual/ThreadAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2019, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -28,7 +28,7 @@
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm --enable-native-access=ALL-UNNAMED ThreadAPI
* @run junit/othervm/native --enable-native-access=ALL-UNNAMED ThreadAPI
*/

/*
Expand All @@ -37,7 +37,7 @@
* @modules java.base/java.lang:+open jdk.management
* @library /test/lib
* @build LockingMode
* @run junit/othervm -XX:+UnlockExperimentalVMOptions -XX:-VMContinuations
* @run junit/othervm/native -XX:+UnlockExperimentalVMOptions -XX:-VMContinuations
* --enable-native-access=ALL-UNNAMED ThreadAPI
*/

Expand Down
7 changes: 4 additions & 3 deletions test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -27,7 +27,7 @@
* @summary Test that Thread.yield loop polls for safepoints
* @requires vm.continuations
* @library /test/lib
* @run junit/othervm ThreadPollOnYield
* @run junit/othervm/native --enable-native-access=ALL-UNNAMED ThreadPollOnYield
*/

/*
Expand All @@ -36,7 +36,8 @@
* @summary Test that Thread.yield loop polls for safepoints
* @requires vm.continuations & vm.compMode != "Xcomp"
* @library /test/lib
* @run junit/othervm -Xcomp -XX:-TieredCompilation -XX:CompileCommand=inline,*::yield* -XX:CompileCommand=inline,*::*Yield ThreadPollOnYield
* @run junit/othervm/native --enable-native-access=ALL-UNNAMED -Xcomp -XX:-TieredCompilation
* -XX:CompileCommand=inline,*::yield* -XX:CompileCommand=inline,*::*Yield ThreadPollOnYield
*/

import java.util.concurrent.atomic.AtomicBoolean;
Expand Down
6 changes: 3 additions & 3 deletions test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2023, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -28,15 +28,15 @@
* @requires vm.debug != true
* @modules jdk.management
* @library /test/lib
* @run main/othervm/timeout=300 --enable-native-access=ALL-UNNAMED GetStackTraceALotWhenPinned 100000
* @run main/othervm/native/timeout=300 --enable-native-access=ALL-UNNAMED GetStackTraceALotWhenPinned 100000
*/

/*
* @test
* @requires vm.debug == true
* @modules jdk.management
* @library /test/lib
* @run main/othervm/timeout=300 --enable-native-access=ALL-UNNAMED GetStackTraceALotWhenPinned 50000
* @run main/othervm/native/timeout=300 --enable-native-access=ALL-UNNAMED GetStackTraceALotWhenPinned 50000
*/

import java.time.Instant;
Expand Down
Loading