-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c #23591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kvn! A progress list of the required criteria for merging this PR into |
|
@vnkozlov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
jianglizhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
|
I will wait GHA builds finish |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine and trivial.
|
/integrate |
|
Going to push as commit 336d0d8. |
Backout change JDK-8349859 because it causes build failure.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23591/head:pull/23591$ git checkout pull/23591Update a local copy of the PR:
$ git checkout pull/23591$ git pull https://git.openjdk.org/jdk.git pull/23591/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23591View PR using the GUI difftool:
$ git pr show -t 23591Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23591.diff
Using Webrev
Link to Webrev Comment