Skip to content

Conversation

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Feb 12, 2025

Backout change JDK-8349859 because it causes build failure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c (Sub-task - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23591/head:pull/23591
$ git checkout pull/23591

Update a local copy of the PR:
$ git checkout pull/23591
$ git pull https://git.openjdk.org/jdk.git pull/23591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23591

View PR using the GUI difftool:
$ git pr show -t 23591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23591.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2025

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 12, 2025

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c

Reviewed-by: jiangli, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2025
@openjdk
Copy link

openjdk bot commented Feb 12, 2025

@vnkozlov The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org client client-libs-dev@openjdk.org labels Feb 12, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2025

Webrevs

Copy link
Contributor

@jianglizhou jianglizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 12, 2025
@vnkozlov
Copy link
Contributor Author

I will wait GHA builds finish

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and trivial.

@vnkozlov
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 12, 2025

Going to push as commit 336d0d8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2025
@openjdk openjdk bot closed this Feb 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2025
@openjdk
Copy link

openjdk bot commented Feb 12, 2025

@vnkozlov Pushed as commit 336d0d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the 8349926 branch February 12, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants