8347040: C2: assert(!loop->_body.contains(in)) failed

[rwestrel]

OuterStripMinedLoopNode::transform_to_counted_loop() merges the
outer strip mined loop and the inner loop into a single loop. To
achieve that, it needs to append the nodes of the outer strip mined
loop to the body of the inner loop. To make sure each of these nodes
is appended only once, a Unique_Node_List is used: nodes found by
following the safepoint's inputs are first enqueued into the list and
then, each unique node should be added to the loop body. That's not
what the current code does, though, because it enqueues the nodes it
finds to the list and add them to the loop body right away.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347040: C2: assert(!loop->_body.contains(in)) failed (Bug - P3)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23676/head:pull/23676
$ git checkout pull/23676

Update a local copy of the PR:
$ git checkout pull/23676
$ git pull https://git.openjdk.org/jdk.git pull/23676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23676

View PR using the GUI difftool:
$ git pr show -t 23676

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23676.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347040: C2: assert(!loop->_body.contains(in)) failed

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 159 new commits pushed to the master branch:

• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• d6d9447: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• e80b76b: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC
• 799ac52: 8314840: 3 gc/epsilon tests ignore external vm options
• 63e0fc4: 8350841: ProblemList jdk/incubator/vector/Long256VectorTests.java
• acc6f19: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails
• 01bd7e4: 8350314: Shenandoah: Capture thread state sync times in GC timings
• 4522f12: 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity
• e4d3c97: 8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP
• ... and 149 more: https://git.openjdk.org/jdk/compare/28e744dc642db8ebe376403f28630438a5ee3f44...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@rwestrel The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (711c36fc)

[chhagedorn]

That looks good to me.

[vnkozlov]

LGTM

[rwestrel]

@chhagedorn @vnkozlov thanks for the reviews

[rwestrel]

/integrate

[openjdk]

Going to push as commit 939815f.
Since your change was applied there have been 159 commits pushed to the master branch:

• 8323ddf: 8346659: SnippetTaglet should report an error if provided ambiguous links
• 3c9d64e: 8350858: [IR Framework] Some tests failed on Cascade Lake
• d6d9447: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
• e80b76b: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC
• 799ac52: 8314840: 3 gc/epsilon tests ignore external vm options
• 63e0fc4: 8350841: ProblemList jdk/incubator/vector/Long256VectorTests.java
• acc6f19: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails
• 01bd7e4: 8350314: Shenandoah: Capture thread state sync times in GC timings
• 4522f12: 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity
• e4d3c97: 8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP
• ... and 149 more: https://git.openjdk.org/jdk/compare/28e744dc642db8ebe376403f28630438a5ee3f44...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel Pushed as commit 939815f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.