8347814: Make all imports consistent in the FFM API tests and benchmarks

[minborg]

This PR proposes to make all imports consistent in the FFM API tests and benchmarks.

This is a follow-up PR from #22827

Passes tier1-3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347814: Make all imports consistent in the FFM API tests and benchmarks (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23689/head:pull/23689
$ git checkout pull/23689

Update a local copy of the PR:
$ git checkout pull/23689
$ git pull https://git.openjdk.org/jdk.git pull/23689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23689

View PR using the GUI difftool:
$ git pr show -t 23689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23689.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e134dbe3)

[bridgekeeper]

@minborg This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@minborg This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[minborg]

/open

[openjdk]

@minborg This pull request is now open

[mrserb]

Duplicate my comment: https://github.com/openjdk/jdk/pull/22827/files#r2059725341

It looks inconsistent that in some places you remove the wildcard (*) imports, while in others you add them.

By the way, where does this convention come from? I believe most of the codebase follows the import order: java → empty line → javax → empty line → other jdk packages in alphabetical order → empty line → repeat the same groups for static imports.

[minborg]

In the end, this didn't make the bar in terms of cost/benefit. For example, backporting might be impacted.

[mrserb]

In the end, this didn't make the bar in terms of cost/benefit. For example, backporting might be impacted.

The first LTS release to include this API will be 25, correct? It would be best to clean this up in advance, as backporting to versions 22, 23, or 24 is unlikely - just a thought.