Skip to content

Conversation

@vpaprotsk
Copy link
Contributor

@vpaprotsk vpaprotsk commented Feb 21, 2025

Add two more models to the list


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350516: Update model numbers for ECore-based cpus (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23731/head:pull/23731
$ git checkout pull/23731

Update a local copy of the PR:
$ git checkout pull/23731
$ git pull https://git.openjdk.org/jdk.git pull/23731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23731

View PR using the GUI difftool:
$ git pr show -t 23731

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23731.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back vpaprotski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@vpaprotsk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350516: Update model numbers for ECore-based cpus

Reviewed-by: sviswanathan, vaivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • b17c0b6: 8350585: InlineSecondarySupersTest must be guarded on ppc64 by COMPILER2
  • 62f39bd: 8350636: Potential null-pointer dereference in MallocSiteTable::new_entry
  • cfeb7d6: 8350497: os::create_thread unify init thread attributes part across UNIX platforms
  • 8cfebc4: 8350571: Remove mention of Tonga test suite from JMX tests
  • c413549: 8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native
  • a9c9f7f: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME
  • aa70f0a: 8347348: Clarify that the HTTP server in jdk.httpserver module is not a full featured server
  • d551dac: 8350103: Test containers/systemd/SystemdMemoryAwarenessTest.java fails on Linux ppc64le SLES15 SP6
  • ab86a13: 8350548: java.lang.classfile package javadoc has errors
  • e1081cf: 8348536: Remove remain SIZE_FORMAT usage after JDK-8347990
  • ... and 15 more: https://git.openjdk.org/jdk/compare/9d9d7a17d3d1a8971712ef1b22e919012350db6f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@vpaprotsk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

Copy link

@sviswa7 sviswa7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2025
Copy link

@IvaVladimir IvaVladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added platforms codes looks OK.

@vpaprotsk
Copy link
Contributor Author

Thanks!

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@vpaprotsk
Your change (at version 7da4a1f) is now ready to be sponsored by a Committer.

@sviswa7
Copy link

sviswa7 commented Feb 25, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

Going to push as commit dea7a9f.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 5023971: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes
  • 08bc59d: 8138614: (spec str) StringBuffer and StringBuilder methods improperly require "new" String to be returned
  • b17c0b6: 8350585: InlineSecondarySupersTest must be guarded on ppc64 by COMPILER2
  • 62f39bd: 8350636: Potential null-pointer dereference in MallocSiteTable::new_entry
  • cfeb7d6: 8350497: os::create_thread unify init thread attributes part across UNIX platforms
  • 8cfebc4: 8350571: Remove mention of Tonga test suite from JMX tests
  • c413549: 8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native
  • a9c9f7f: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME
  • aa70f0a: 8347348: Clarify that the HTTP server in jdk.httpserver module is not a full featured server
  • d551dac: 8350103: Test containers/systemd/SystemdMemoryAwarenessTest.java fails on Linux ppc64le SLES15 SP6
  • ... and 17 more: https://git.openjdk.org/jdk/compare/9d9d7a17d3d1a8971712ef1b22e919012350db6f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 25, 2025
@openjdk openjdk bot closed this Feb 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@sviswa7 @vpaprotsk Pushed as commit dea7a9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants