Skip to content

8350649: Class unloading accesses/resurrects dead Java mirror after JDK-8346567 #23775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shipilev wants to merge 6 commits into from
Closed

8350649: Class unloading accesses/resurrects dead Java mirror after JDK-8346567 #23775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
acbe84c
Fix
shipilev Feb 25, 2025
7269b44
Re-introduce Klass cache
shipilev Feb 25, 2025
c302a4a
Alternate fix: compute modifiers directly
shipilev Feb 25, 2025
f49438c
Better comments
shipilev Feb 25, 2025
8a77e58
More comment polishing, getting too late here for doing this without …
shipilev Feb 25, 2025
0275ed1
Drop "is"
shipilev Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ static void do_write_klass(JfrCheckpointWriter* writer, CldPtr cld, KlassPtr kla
writer->write(cld != nullptr ? cld_id(cld, leakp) : 0);
writer->write(mark_symbol(klass, leakp));
writer->write(package_id(klass, leakp));
writer->write(klass->modifier_flags());
writer->write(klass->compute_modifier_flags());
writer->write<bool>(klass->is_hidden());
if (leakp) {
assert(IS_LEAKP(klass), "invariant");
Expand Down
7 changes: 6 additions & 1 deletion src/hotspot/share/oops/klass.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,9 +749,14 @@ class Klass : public Metadata {
virtual void release_C_heap_structures(bool release_constant_pool = true);

public:
virtual u2 compute_modifier_flags() const = 0;
// Get modifier flags from Java mirror cache.
int modifier_flags() const;

// Compute modifier flags from the original data. This also allows
// accessing flags when Java mirror is already dead, e.g. during class
// unloading.
virtual u2 compute_modifier_flags() const = 0;

// JVMTI support
virtual jint jvmti_class_status() const;

Expand Down