8350667: Remove startThread_lock() and _startThread_lock on AIX

[MBaesken]

The startThread_lock() and _startThread_lock coding is not used on AIX so it can be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350667: Remove startThread_lock() and _startThread_lock on AIX (Bug - P4)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Joachim Kern (@JoKern65 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23779/head:pull/23779
$ git checkout pull/23779

Update a local copy of the PR:
$ git checkout pull/23779
$ git pull https://git.openjdk.org/jdk.git pull/23779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23779

View PR using the GUI difftool:
$ git pr show -t 23779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23779.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350667: Remove startThread_lock() and _startThread_lock on AIX

Reviewed-by: stuefe, jkern

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• a431046: 8350518: org.openjdk.bench.java.util.TreeMapUpdate.compute fails with "java.lang.IllegalArgumentException: key out of range"
• a70eba8: 8330174: Protection zone for easier detection of accidental zero-nKlass use
• f529bf7: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
• 037e471: 8350666: cmp-baseline builds fail after JDK-8280682
• c8a521f: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12
• 86024eb: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file
• 267d69b: 8326447: jpackage creates Windows installers that cannot be signed
• 2efb033: 8350601: Miscellaneous updates to jpackage test lib
• d4fdc79: 8344981: [REDO] JDK-6672644 JComboBox still scrolling if switch to another window and return back
• b78043f: 8320220: Compilation of cyclic hierarchy causes infinite recursion
• ... and 6 more: https://git.openjdk.org/jdk/compare/50239716403732fe8af73b4b6f006b6a4b7b22db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1a5e20f7)

[tstuefe]

ok

[dholmes-ora]

It is interesting that on Windows, where we also start threads suspended, we also do:

// Thread state now is INITIALIZED, not SUSPENDED
  osthread->set_state(INITIALIZED);

then we have:

  // The thread is returned suspended (in state INITIALIZED), and is started higher up in the call chain
  return true;

[dholmes-ora]

But I see now that states ALLOCATED and INITIALIZED are really only needed for the parent/child handshake.

[JoKern65]

LGTM

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit e7d4b36.
Since your change was applied there have been 19 commits pushed to the master branch:

• 1e18fff: 8328473: StringTable and SymbolTable statistics delay time to safepoint
• a0dd565: 8350643: G1: Make loop iteration variable type correspond to limit in G1SurvRateGroup
• aac9cb4: 8349906: G1: Improve initial survivor rate for newly used young regions
• a431046: 8350518: org.openjdk.bench.java.util.TreeMapUpdate.compute fails with "java.lang.IllegalArgumentException: key out of range"
• a70eba8: 8330174: Protection zone for easier detection of accidental zero-nKlass use
• f529bf7: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
• 037e471: 8350666: cmp-baseline builds fail after JDK-8280682
• c8a521f: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12
• 86024eb: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file
• 267d69b: 8326447: jpackage creates Windows installers that cannot be signed
• ... and 9 more: https://git.openjdk.org/jdk/compare/50239716403732fe8af73b4b6f006b6a4b7b22db...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit e7d4b36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.