-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError #23814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8a2fa6c
8350813: Rendering of bulky sound bank from MIDI sequence can cause O…
azuev-java e48e16a
Update test/jdk/javax/sound/midi/BulkSoundBank/BulkSoundBank.java
azuev-java e02c586
Remove extra whitespace
azuev-java a990c82
Add a treshold of 90% to avoid OOME because of the additional buffers…
azuev-java ae6ac1c
Merge branch 'JDK-8350813' of https://github.com/azuev-java/jdk into …
azuev-java File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
test/jdk/javax/sound/midi/BulkSoundBank/BulkSoundBank.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. | ||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
* | ||
* This code is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 only, as | ||
* published by the Free Software Foundation. | ||
* | ||
* This code is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
* version 2 for more details (a copy is included in the LICENSE file that | ||
* accompanied this code). | ||
* | ||
* You should have received a copy of the GNU General Public License version | ||
* 2 along with this work; if not, write to the Free Software Foundation, | ||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
* | ||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
* or visit www.oracle.com if you need additional information or have any | ||
* questions. | ||
*/ | ||
|
||
import javax.sound.midi.InvalidMidiDataException; | ||
import javax.sound.midi.MidiSystem; | ||
import java.io.ByteArrayInputStream; | ||
import java.io.IOException; | ||
|
||
/** | ||
* @test | ||
* @bug 8350813 | ||
* @summary Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError. | ||
* @run main/othervm -Xmx1g BulkSoundBank | ||
*/ | ||
|
||
public class BulkSoundBank { | ||
static final byte[] midi = {77, 84, 104, 100, 0, 0, 0, 6, 0, 0, 0, 1, 1, | ||
-32, 77, 84, 114, 107, 0, 0, 0, 50, 0, -1, 88, 4, 4, 2, 24, 8, 0, -1, | ||
81, 3, 7, -95, 32, 0, -112, 60, 64, -125, 96, -128, 60, 64, -125, -44, | ||
-51, 32, -112, 48, 64, 1, -128, 48, 64, -127, -64, -45, 127, -112, 60, | ||
64, 1, -128, 60, 64, 0, -1, 47, 0}; | ||
|
||
public static void main(String[] args) throws IOException { | ||
try (ByteArrayInputStream bis = new ByteArrayInputStream(midi)) { | ||
MidiSystem.getSoundbank(bis); | ||
throw new RuntimeException("Test should throw InvalidMidiDataException" | ||
+ " but it did not."); | ||
} catch (InvalidMidiDataException imda) { | ||
System.out.println("Caught InvalidMidiDataException as expected"); | ||
} | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test can still throw OOME with
@run main/othervm -Xmx2g BulkSoundBank
after the fix. (Tested on Ubuntu 22.04)So it looks like the condition when we throw the
InvalidMidiDataException
should be tuned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not predict OOME reliably - if size of the rendered data is 99% of the remaining heap and the file i/o or background task takes more than 2% of it - the memory will eventually end, there always will be corner cases no matter what treshold we choose. In the end rendering such a huge bank will take minutes and background task might consume more memory at the time. The code here stops OOME when we know for sure we will not have enough resources and lowering the amount might stop the legitimate use case from working.