8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore

[fguallini]

The following tests are marked with @ignore (not running):

• sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting the clientMode after the handshake has begun is not permitted, but this was failing intermittently due to a race condition, it was possible that SetClientMode was called before the client socket was updated with handshake isNegotiated = true. The fix is to introduce a latch to sync between client and main threads. Included additional refactoring to ensure test stability.

• sun/security/ssl/SSLSocketImpl/NonAutoClose.java: This test should only run in TLS <= 1.2, as TLSv1.3 changes the behaviour of close_notify. Included additional refactoring to ensure test stability.

Executed both tests 10K times, no test flakiness found

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore (Sub-task - P4)

Reviewers

• Artur Barashev (@artur-oracle - Author)
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23898/head:pull/23898
$ git checkout pull/23898

Update a local copy of the PR:
$ git checkout pull/23898
$ git pull https://git.openjdk.org/jdk.git pull/23898/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23898

View PR using the GUI difftool:
$ git pr show -t 23898

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23898.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore

Reviewed-by: abarashev, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1044 new commits pushed to the master branch:

• 52a5583: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException
• 3e258cb: 8356407: Part of class verification is skipped in AOT training run
• 7642556: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer
• ... and 1041 more: https://git.openjdk.org/jdk/compare/bb70896e356536477cfb770096fb769485edc55b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@fguallini The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (2741a197)
• 02: Full - Incremental (0133c60f)
• 01: Full - Incremental (b6ac1491)
• 00: Full (837ddd1b)

[mpdonova]

Looks good to me!

[artur-oracle]

LGTM

[bridgekeeper]

@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[fguallini]

Please, this needs a reviewer's approval

[rhalade]

Fix looks good to me.

[fguallini]

/integrate

[openjdk]

Going to push as commit 86f39ab.
Since your change was applied there have been 1160 commits pushed to the master branch:

• fc6f4da: 8351666: [PPC64] Make non-volatile VectorRegisters available for C2 register allocation
• b76b610: 8356869: RISC-V: Improve tail handling of array fill stub
• 265bc5f: 8353496: SuspendResume1.java and SuspendResume2.java timeout after JDK-8319447
• ... and 1157 more: https://git.openjdk.org/jdk/compare/bb70896e356536477cfb770096fb769485edc55b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fguallini Pushed as commit 86f39ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.