Skip to content

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 25, 2025

Fixed wrong test class in @run statement and fixed comment style in three unrelated tests.

Best regards,
Tobias


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352866: TestLogJIT.java runs wrong test class (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24221/head:pull/24221
$ git checkout pull/24221

Update a local copy of the PR:
$ git checkout pull/24221
$ git pull https://git.openjdk.org/jdk.git pull/24221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24221

View PR using the GUI difftool:
$ git pr show -t 24221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24221.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352866: TestLogJIT.java runs wrong test class

Reviewed-by: rcastanedalo, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • bab9372: 8352618: Remove old deprecated functionality in the build system
  • 512b9b1: 8196896: Use SYSROOT_CFLAGS in dtrace gensrc
  • 721ef76: 8352696: JFR: assert(false): EA: missing memory path
  • c002b97: 8352676: Opensource JMenu tests - series1
  • bdcac98: 8347459: C2: missing transformation for chain of shifts/multiplications by constants

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2025
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@TobiHartmann
Copy link
Member Author

Thanks for the reviews Roberto and Christian!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

Going to push as commit 67c4405.
Since your change was applied there have been 5 commits pushed to the master branch:

  • bab9372: 8352618: Remove old deprecated functionality in the build system
  • 512b9b1: 8196896: Use SYSROOT_CFLAGS in dtrace gensrc
  • 721ef76: 8352696: JFR: assert(false): EA: missing memory path
  • c002b97: 8352676: Opensource JMenu tests - series1
  • bdcac98: 8347459: C2: missing transformation for chain of shifts/multiplications by constants

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2025
@openjdk openjdk bot closed this Mar 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@TobiHartmann Pushed as commit 67c4405.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants