Skip to content

Conversation

@robehn
Copy link
Contributor

@robehn robehn commented Mar 25, 2025

Hi, please consider.

gcc have stopped emitting io-bits for fences since 13.
And we need to use newer gcc due to other compiler bugs.
Therefore there is no point in letting JIT emit io-bits when the runtime don't have them.

Thanks, Robbin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352897: RISC-V: Change default value for UseConservativeFence (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24233/head:pull/24233
$ git checkout pull/24233

Update a local copy of the PR:
$ git checkout pull/24233
$ git pull https://git.openjdk.org/jdk.git pull/24233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24233

View PR using the GUI difftool:
$ git pr show -t 24233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24233.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352897: RISC-V: Change default value for UseConservativeFence

Reviewed-by: luhenry, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • a81250c: 8352673: RISC-V: Vector can't be turned on with -XX:+UseRVV
  • 0935ba9: 8352481: Enforce the use of lld with clang
  • dbc620f: 8352299: GenShen: Young cycles that interrupt old cycles cannot be cancelled
  • f5a0db4: 8315447: Invalid Type Annotation attached to a method instead of a lambda
  • 60544a1: 8164714: Constructor.newInstance creates instance of inner class with null outer class
  • c856b34: 8352587: C2 SuperWord: we must avoid Multiversioning for PeelMainPost loops
  • 993eae4: 8346948: Update CLDR to Version 47.0
  • e98838f: 8352065: [PPC64] C2: Implement PopCountVL, CountLeadingZerosV and CountTrailingZerosV nodes
  • 03105fc: 8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config
  • fe03e2e: 8351897: Extra closing curly brace typos in Javadoc
  • ... and 12 more: https://git.openjdk.org/jdk/compare/6879c446c6e7734c162c85bd2bd3d7f3b012cca4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@robehn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

@robehn
Copy link
Contributor Author

robehn commented Mar 25, 2025

Thank you @luhenry !

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 26, 2025
@robehn
Copy link
Contributor Author

robehn commented Mar 27, 2025

Thanks @RealFYang!

@robehn
Copy link
Contributor Author

robehn commented Mar 27, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2025

Going to push as commit 1007811.
Since your change was applied there have been 46 commits pushed to the master branch:

  • 7853415: 8352218: RISC-V: Zvfh requires RVV
  • 2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
  • 1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
  • 441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
  • e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
  • 5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
  • c2a4fed: 8348907: Stress times out when is executed with ZGC
  • 5392674: 8352766: Problemlist hotspot tier1 tests requiring tools that are not included in static JDK
  • 1d205f5: 8352716: (tz) Update Timezone Data to 2025b
  • a2a64da: 8352588: GenShen: Enabling JFR asserts when getting GCId
  • ... and 36 more: https://git.openjdk.org/jdk/compare/6879c446c6e7734c162c85bd2bd3d7f3b012cca4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2025
@openjdk openjdk bot closed this Mar 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@robehn Pushed as commit 1007811.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn robehn deleted the fence_io branch May 9, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants