8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself #24240

marc-chevalier · 2025-03-26T07:36:37Z

Simply changing the path in @run was not enough (see JBS for details). And actually, the test wasn't doing anything before trying to open an output file to check the result. From various hints, I completed the test: I hope it was the intent!

I think @chhagedorn's eye would be the most relevant.

Thanks,
Marc

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself (Bug - P4)

Reviewers

Christian Hagedorn (@chhagedorn - Reviewer)
Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24240/head:pull/24240
$ git checkout pull/24240

Update a local copy of the PR:
$ git checkout pull/24240
$ git pull https://git.openjdk.org/jdk.git pull/24240/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24240

View PR using the GUI difftool:
$ git pr show -t 24240

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24240.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-03-26T07:37:22Z

👋 Welcome back mchevalier! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-03-26T07:38:11Z

@marc-chevalier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

4100dc9: 8350801: Add a code signing hook to the JDK build system
8a40498: 8352678: Opensource few JMenuItem tests
66b5dba: 8350988: Consolidate Identity of self-inverse operations
1007811: 8352897: RISC-V: Change default value for UseConservativeFence
7853415: 8352218: RISC-V: Zvfh requires RVV
2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
... and 37 more: https://git.openjdk.org/jdk/compare/bdcac98673a2250f608bdf244e17578eecb30fbe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-03-26T07:38:42Z

@marc-chevalier The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

marc-chevalier · 2025-03-26T08:50:32Z

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/flag/TestCompileCommandFileWriter.java


    private void check(Class<?> testClass, boolean findIdeal, boolean findOpto, CompilePhase... compilePhases) throws IOException {
+        var compilerDirectivesFlagBuilder = new CompilerDirectivesFlagBuilder(testClass);
+        compilerDirectivesFlagBuilder.build();


I was tempted to write

new CompilerDirectivesFlagBuilder(testClass).build();

since we don't use compilerDirectivesFlagBuilder after. But I felt like the style might not be liked. Opinions on that?

I guess it's fine to go with new CompilerDirectivesFlagBuilder(testClass).build().

If there is no strong preference, I'll just leave it as it is: having the variable doesn't hurt, as far as I know, and it helps slightly if one wants to debug, to make a breakpoint, to inspect the state of the object etc..

chhagedorn

Good catch! I'm not sure why I removed this one line. It surely must have been exactly what you added now. Maybe I was doing some last experiments and somehow messed up to push it properly and then we missed it because it was actually not even run.

chhagedorn · 2025-03-26T09:34:49Z

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/flag/TestCompileCommandFileWriter.java


    private void check(Class<?> testClass, boolean findIdeal, boolean findOpto, CompilePhase... compilePhases) throws IOException {
+        var compilerDirectivesFlagBuilder = new CompilerDirectivesFlagBuilder(testClass);
+        compilerDirectivesFlagBuilder.build();


I guess it's fine to go with new CompilerDirectivesFlagBuilder(testClass).build().

mlbridge · 2025-03-26T09:41:26Z

Webrevs

01: Full - Incremental (437a4913)
00: Full (321ebab8)

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/flag/TestCompileCommandFileWriter.java

marc-chevalier · 2025-03-27T08:45:41Z

Fixed as requested. Also, vm.debug == true seems unnecessary.

TobiHartmann

Looks good.

marc-chevalier · 2025-03-27T10:27:35Z

/integrate

Thanks @chhagedorn and @TobiHartmann !

openjdk · 2025-03-27T10:28:05Z

@marc-chevalier
Your change (at version 437a491) is now ready to be sponsored by a Committer.

chhagedorn · 2025-03-27T11:34:56Z

/sponsor

openjdk · 2025-03-27T11:36:16Z

Going to push as commit 927aeb2.
Since your change was applied there have been 50 commits pushed to the master branch:

0bfa636: 8352426: RelocIterator should correctly handle nullptr address of relocation data
b7ffd22: 8352980: Purge infrastructure for FP-to-bits interpreter intrinsics after 32-bit x86 removal
9a87e21: 8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106
4100dc9: 8350801: Add a code signing hook to the JDK build system
8a40498: 8352678: Opensource few JMenuItem tests
66b5dba: 8350988: Consolidate Identity of self-inverse operations
1007811: 8352897: RISC-V: Change default value for UseConservativeFence
7853415: 8352218: RISC-V: Zvfh requires RVV
2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
... and 40 more: https://git.openjdk.org/jdk/compare/bdcac98673a2250f608bdf244e17578eecb30fbe...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-03-27T11:36:32Z

@chhagedorn @marc-chevalier Pushed as commit 927aeb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Make TestCompileCommandFileWriter run itself

321ebab

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 26, 2025

marc-chevalier commented Mar 26, 2025

View reviewed changes

marc-chevalier marked this pull request as ready for review March 26, 2025 09:36

chhagedorn approved these changes Mar 26, 2025

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2025

TobiHartmann reviewed Mar 27, 2025

View reviewed changes

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/flag/TestCompileCommandFileWriter.java Show resolved Hide resolved

fix copyright and remove IgnoreUnrecognizedVMOptions and remove vm.debug

437a491

openjdk bot removed the ready Pull request is ready to be integrated label Mar 27, 2025

chhagedorn approved these changes Mar 27, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 27, 2025

TobiHartmann approved these changes Mar 27, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 27, 2025

openjdk bot added the integrated Pull request has been integrated label Mar 27, 2025

openjdk bot closed this Mar 27, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 27, 2025

8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself #24240

8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself #24240

Uh oh!

Conversation

marc-chevalier commented Mar 26, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 26, 2025

Uh oh!

openjdk bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 26, 2025

Uh oh!

marc-chevalier Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

chhagedorn Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

marc-chevalier Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

chhagedorn left a comment

Choose a reason for hiding this comment

Uh oh!

chhagedorn Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

mlbridge bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

marc-chevalier commented Mar 27, 2025

Uh oh!

TobiHartmann left a comment

Choose a reason for hiding this comment

Uh oh!

marc-chevalier commented Mar 27, 2025

Uh oh!

openjdk bot commented Mar 27, 2025

Uh oh!

chhagedorn commented Mar 27, 2025

Uh oh!

openjdk bot commented Mar 27, 2025

Uh oh!

openjdk bot commented Mar 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

marc-chevalier commented Mar 26, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Mar 26, 2025 •

edited

Loading

mlbridge bot commented Mar 26, 2025 •

edited

Loading