8352896: LambdaExpr02.java runs wrong test class

[linzihao1999]

Fix LambdaExpr02.java runs wrong test class.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352896: LambdaExpr02.java runs wrong test class (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24277/head:pull/24277
$ git checkout pull/24277

Update a local copy of the PR:
$ git checkout pull/24277
$ git pull https://git.openjdk.org/jdk.git pull/24277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24277

View PR using the GUI difftool:
$ git pr show -t 24277

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24277.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back linzihao1999! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@linzihao1999 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352896: LambdaExpr02.java runs wrong test class

Reviewed-by: shade, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 3e9a7a4: 8353063: make/ide/vscode: Invalid Configuration Values
• 8ef7832: 8350471: Unhandled compilation bailout in GraphKit::builtin_throw
• ddf326b: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
• bac2aa4: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table
• cfc648b: 8352677: Opensource JMenu tests - series2
• 2ea1557: 8353005: AIX build broken after 8352481
• f4428e8: 8352920: Compilation failure: comparison of unsigned expression >= 0 is always true
• d5b12c8: 8352890: Remove unnecessary Windows version check in FileFontStrike
• 58ef401: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter
• 4ce9b4c: 8352435: Refactor CDS test library for execution and module packaging
• ... and 8 more: https://git.openjdk.org/jdk/compare/41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @liach, @lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@linzihao1999 The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (6dd3941e)
• 01: Full - Incremental (5c7cc21d)
• 00: Full (6dd3941e)

[shipilev]

Ha! Looks good.

[linzihao1999]

/integrate

[openjdk]

@linzihao1999
Your change (at version 6dd3941) is now ready to be sponsored by a Committer.

[liach]

Should we just drop main Xxx as this is automatically added by jtreg?

[linzihao1999]

Should we just drop main Xxx as this is automatically added by jtreg?

That make sense. Just drop the @run main only if test have customize action.

[shipilev]

Sorry, but this is not what other tests in the same directory do. Leave it at

 * @run main LambdaExpr02

[openjdk]

@linzihao1999 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[liach]

Guess we will fix this when jtreg introduces something like @this in the future...

[liach]

@lahodaj What do you think on this one?

[lahodaj]

I don't have a very strong preference between nothing, @run main <testname> and:

@compile <testname>.java
@run main <testname>

The latter is sometime good specifically for javac, as it forces compilation, and that is desirable while developing javac (because for @build/@run main, it may happen an updated javac is not used to compile the given test, as the test is already compiled).

But, that's not strong enough to alter long-existing test headers. So, keeping things more or less as they are, and consistent across the directory seems good.

[vicente-romero-oracle]

/sponsor

[openjdk]

Going to push as commit c029220.
Since your change was applied there have been 19 commits pushed to the master branch:

• c0b61d3: 8352680: Opensource few misc swing tests
• 3e9a7a4: 8353063: make/ide/vscode: Invalid Configuration Values
• 8ef7832: 8350471: Unhandled compilation bailout in GraphKit::builtin_throw
• ddf326b: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
• bac2aa4: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table
• cfc648b: 8352677: Opensource JMenu tests - series2
• 2ea1557: 8353005: AIX build broken after 8352481
• f4428e8: 8352920: Compilation failure: comparison of unsigned expression >= 0 is always true
• d5b12c8: 8352890: Remove unnecessary Windows version check in FileFontStrike
• 58ef401: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter
• ... and 9 more: https://git.openjdk.org/jdk/compare/41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle @linzihao1999 Pushed as commit c029220.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.