Skip to content

8353189: [ASAN] memory leak after 8352184 #24299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sendaoYan wants to merge 4 commits into from
Closed

8353189: [ASAN] memory leak after 8352184 #24299

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71bc3ad
8353189: [ASAN] memory leak after 8352184
Mar 28, 2025
1110385
Revert "8353189: [ASAN] memory leak after 8352184"
Apr 7, 2025
9d039fd
Use static static string instead of assemble string dynamic
Apr 7, 2025
461b0f8
add a comment to explain why we avoid dynamic memory allocation for t…
Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions src/hotspot/share/runtime/abstract_vm_version.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,42 +137,46 @@ const char* Abstract_VM_Version::vm_vendor() {
}


// The VM info string should be a constant, but its value cannot be finalized until after VM arguments
// have been fully processed. And we want to avoid dynamic memory allocation which will cause ASAN
// report error, so we enumerate all the cases by static const string value.
const char* Abstract_VM_Version::vm_info_string() {
Copy link
Contributor

@jianglizhou jianglizhou Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future benefit, how about also adding a comment explain why we avoid dynamic memory allocation for the vm_info_string here?

Copy link
Member Author

@sendaoYan sendaoYan Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have add a comment, but my English is not very well. If you have proper description, please let me known.

Copy link
Contributor

@jianglizhou jianglizhou Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, thanks. Please update the contributor properly since the change is from baff6b1.

Copy link
Member Author

@sendaoYan sendaoYan Apr 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, that was my original plan also.

By the way, do you mind add David Holmes as contributor also, because he do lots of investigation on this issue?

Copy link
Contributor

@jianglizhou jianglizhou Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

const char* mode;
switch (Arguments::mode()) {
case Arguments::_int:
mode = "interpreted mode";
break;
if (is_vm_statically_linked()) {
return CDSConfig::is_using_archive() ? "interpreted mode, static, sharing" : "interpreted mode, static";
} else {
return CDSConfig::is_using_archive() ? "interpreted mode, sharing" : "interpreted mode";
}
case Arguments::_mixed:
if (CompilationModeFlag::quick_only()) {
mode = "mixed mode, emulated-client";
if (is_vm_statically_linked()) {
if (CompilationModeFlag::quick_only()) {
return CDSConfig::is_using_archive() ? "mixed mode, emulated-client, static, sharing" : "mixed mode, emulated-client, static";
} else {
return CDSConfig::is_using_archive() ? "mixed mode, static, sharing" : "mixed mode, static";
}
} else {
mode = "mixed mode";
if (CompilationModeFlag::quick_only()) {
return CDSConfig::is_using_archive() ? "mixed mode, emulated-client, sharing" : "mixed mode, emulated-client";
} else {
return CDSConfig::is_using_archive() ? "mixed mode, sharing" : "mixed mode";
}
}
break;
case Arguments::_comp:
if (CompilationModeFlag::quick_only()) {
mode = "compiled mode, emulated-client";
if (is_vm_statically_linked()) {
if (CompilationModeFlag::quick_only()) {
return CDSConfig::is_using_archive() ? "compiled mode, emulated-client, static, sharing" : "compiled mode, emulated-client, static";
}
return CDSConfig::is_using_archive() ? "compiled mode, static, sharing" : "compiled mode, static";
} else {
mode = "compiled mode";
if (CompilationModeFlag::quick_only()) {
return CDSConfig::is_using_archive() ? "compiled mode, emulated-client, sharing" : "compiled mode, emulated-client";
}
return CDSConfig::is_using_archive() ? "compiled mode, sharing" : "compiled mode";
}
break;
default:
ShouldNotReachHere();
}

const char* static_info = ", static";
const char* sharing_info = ", sharing";
size_t len = strlen(mode) +
(is_vm_statically_linked() ? strlen(static_info) : 0) +
(CDSConfig::is_using_archive() ? strlen(sharing_info) : 0) +
1;
char* vm_info = NEW_C_HEAP_ARRAY(char, len, mtInternal);
// jio_snprintf places null character in the last character.
jio_snprintf(vm_info, len, "%s%s%s", mode,
is_vm_statically_linked() ? static_info : "",
CDSConfig::is_using_archive() ? sharing_info : "");
return vm_info;
ShouldNotReachHere();
return "";
}

// NOTE: do *not* use stringStream. this function is called by
Expand Down