Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Mar 28, 2025

Proposing to remove the java.locale.useOldISOCodes system property. This property is for backward compatibility introduced back in JDK17 and I believe it is now fine to remove it. In this PR targeting JDK25, it emits a deprecate-for-removal warning on startup if the system property is set to true (no behavioral change except the warning). The plan is eventually to remove it after JDK25. A corresponding CSR has been drafted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8353120 to be approved

Issues

  • JDK-8353118: Deprecate the use of java.locale.useOldISOCodes system property (Bug - P4)
  • JDK-8353120: Deprecate the use of java.locale.useOldISOCodes system property (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24302/head:pull/24302
$ git checkout pull/24302

Update a local copy of the PR:
$ git checkout pull/24302
$ git pull https://git.openjdk.org/jdk.git pull/24302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24302

View PR using the GUI difftool:
$ git pr show -t 24302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24302.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353118: Deprecate the use of `java.locale.useOldISOCodes` system property

Reviewed-by: iris, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

  • fe8bd75: 8351290: Clarify integral only for vector operators
  • 4d1de46: 8352185: Shenandoah: Invalid logic for remembered set verification
  • 3e96f5c: 8351366: Remove the java.security.debug=scl option
  • 4247744: 8351435: Change the default Console implementation back to the built-in one in java.base module
  • 9c06dcb: 8349583: Add mechanism to disable signature schemes based on their TLS scope
  • cd5a43a: 8353126: Open source events tests batch1
  • e4e6278: 8346129: Simplify EdDSA & XDH curve name usage
  • 7a2e198: 8352277: java.security documentation: incorrect regex syntax describing "usage" algorithm constraint
  • b7ca76e: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException
  • bbd5b17: 8339280: jarsigner -verify performs cross-checking between CEN and LOC
  • ... and 106 more: https://git.openjdk.org/jdk/compare/6e6a39d35fda929300c7668fdf5d2f0fbfed0606...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 28, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2025

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Associated CSR Reviewed.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Mar 31, 2025
@naotoj
Copy link
Member Author

naotoj commented Apr 1, 2025

Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

Going to push as commit 564066d.
Since your change was applied there have been 134 commits pushed to the master branch:

  • a1ab1d8: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
  • 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing
  • 1809138: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files
  • cef5610: 8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
  • 6801eb8: 8352709: Remove bad timing annotations from WhileOpTest.java
  • 85a0baf: 8352719: Add an equals sign to the modules statement
  • f25f701: 8353226: JFR: emit old object samples must be transitive closure complete for segment
  • aff5aa7: 8350566: NMT: add size parameter to MemTracker::record_virtual_memory_tag
  • 196334f: 8352046: Test testEcoFriendly() in jdk tools launcher ExecutionEnvironment.java for AIX and Linux/musl is brittle
  • ad48846: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing
  • ... and 124 more: https://git.openjdk.org/jdk/compare/6e6a39d35fda929300c7668fdf5d2f0fbfed0606...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2025
@openjdk openjdk bot closed this Apr 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@naotoj Pushed as commit 564066d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants