-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8353118: Deprecate the use of java.locale.useOldISOCodes system property
#24302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 116 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
irisclark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Associated CSR Reviewed.
|
Thanks for the reviews! |
|
Going to push as commit 564066d.
Your commit was automatically rebased without conflicts. |
Proposing to remove the
java.locale.useOldISOCodessystem property. This property is for backward compatibility introduced back in JDK17 and I believe it is now fine to remove it. In this PR targeting JDK25, it emits a deprecate-for-removal warning on startup if the system property is set to true (no behavioral change except the warning). The plan is eventually to remove it after JDK25. A corresponding CSR has been drafted.Progress
Issues
java.locale.useOldISOCodessystem property (Bug - P4)java.locale.useOldISOCodessystem property (CSR)Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24302/head:pull/24302$ git checkout pull/24302Update a local copy of the PR:
$ git checkout pull/24302$ git pull https://git.openjdk.org/jdk.git pull/24302/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24302View PR using the GUI difftool:
$ git pr show -t 24302Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24302.diff
Using Webrev
Link to Webrev Comment