8352768: CDS test MethodHandleTest.java failed in -Xcomp mode

[iklam]

The failure happens because java/lang/invoke/VarHandleGuards is missing from the list of AOT-initialized classes. Please see the JBS issue for details.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352768: CDS test MethodHandleTest.java failed in -Xcomp mode (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)
• Vladimir Ivanov (@iwanowww - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24321/head:pull/24321
$ git checkout pull/24321

Update a local copy of the PR:
$ git checkout pull/24321
$ git pull https://git.openjdk.org/jdk.git pull/24321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24321

View PR using the GUI difftool:
$ git pr show -t 24321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24321.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352768: CDS test MethodHandleTest.java failed in -Xcomp mode

Reviewed-by: dholmes, shade, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• e4e6278: 8346129: Simplify EdDSA & XDH curve name usage
• 7a2e198: 8352277: java.security documentation: incorrect regex syntax describing "usage" algorithm constraint
• b7ca76e: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException
• bbd5b17: 8339280: jarsigner -verify performs cross-checking between CEN and LOC
• d4d1835: 8352860: Open source events tests batch0
• c9c3c15: 8330598: java/net/httpclient/Http1ChunkedTest.java fails with java.util.MissingFormatArgumentException: Format specifier '%s'
• 804a8fa: 8352765: G1CollectedHeap::expand_and_allocate() may fail to allocate even after heap expansion succeeds
• 22f630c: 8352415: x86: Tighten up template interpreter method entry code
• 6fbaa06: 8353176: C1: x86 patching stub always calls Thread::current()
• 79d0c94: 8352114: New test runtime/interpreter/CountBytecodesTest.java is failing
• ... and 21 more: https://git.openjdk.org/jdk/compare/58ef4015b7313292a7c7634d3e00e3a904bbdc50...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e3decb40)

[dholmes-ora]

Okay - seems trivial. Ship it!

Thanks

[iwanowww]

Looks good.

[iklam]

Thanks @dholmes-ora @shipilev @iwanowww for the review
/integraye

[openjdk]

@iklam Unknown command integraye - for a list of valid commands use /help.

[iklam]

/integrate

[openjdk]

Going to push as commit 5eee32d.
Since your change was applied there have been 38 commits pushed to the master branch:

• 8b0602d: 8319447: Improve performance of delayed task handling
• fe8bd75: 8351290: Clarify integral only for vector operators
• 4d1de46: 8352185: Shenandoah: Invalid logic for remembered set verification
• 3e96f5c: 8351366: Remove the java.security.debug=scl option
• 4247744: 8351435: Change the default Console implementation back to the built-in one in java.base module
• 9c06dcb: 8349583: Add mechanism to disable signature schemes based on their TLS scope
• cd5a43a: 8353126: Open source events tests batch1
• e4e6278: 8346129: Simplify EdDSA & XDH curve name usage
• 7a2e198: 8352277: java.security documentation: incorrect regex syntax describing "usage" algorithm constraint
• b7ca76e: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException
• ... and 28 more: https://git.openjdk.org/jdk/compare/58ef4015b7313292a7c7634d3e00e3a904bbdc50...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 5eee32d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.