-
Couldn't load subscription status.
- Fork 6.1k
8353500: [s390x] Intrinsify Unsafe::setMemory #24480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e7cf3a8
s390: unsafe::setMemory Port
offamitkumar bfbf99b
reviews from Lutz and Martin
offamitkumar a6af6da
minor improvement
offamitkumar 7e3bb5e
Revert "minor improvement"
offamitkumar 1b8ea8b
reviews for Martin
offamitkumar f1d075a
[wip] initial mvc template solution
offamitkumar 36ef2e4
wip: fixed the regression
offamitkumar 1fc63a3
extra line
offamitkumar 14e7654
fix testcases
offamitkumar 99dd07c
improvement
offamitkumar cf709ee
extra line
offamitkumar f75209f
improved mvc implementation
offamitkumar d79a841
switch to vector stores
offamitkumar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also use
z_vzero(Vreg)to preload the vector register with all zeroes. Saves an instruction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not loading 0 here. This is my intention: with
z_vlvgb, putting value ofbyteValin the first 0th index ofZ_V0and then withz_vrepbreplicating the0thindex value (1 byte) to the whole register.z_vzerowill make sense if we are zeroing out the memory but that's not the case always. We do fill some non-zero 1 byte value in most of the case.