8354077: Get rid of offscreenSharingEnabled windows flag

[mrserb]

Another unused obsoleted flag removed (offscreenSharingEnabled) from WindowsFlags. Its last usage was eliminated by JDK-6725214 ("D3D: forward-port the new pipeline from 6u10"), see commit.

Interestingly, the original JDK 6u10 changes marked many options as "Obsoleted" (see System Properties for Java 2D Technology). Some of them later were removed in JDK 9 via JDK-8155682 ("Get rid of legacy Windows Flags for DX").

However, two obsoleted flags remain:

• sun.java2d.noddraw: Obsoleted in: Java SE 6 Update 10, which contains a new implementation of D3D support. Setting sun.java2d.noddraw=true is now interpreted exactly the same as disabling that via sun.java2d.d3d=false.
  Intended use: To turn off the Java 2D system's use of DirectDraw and Direct3D completely.
  Introduced: 1.2
  Default value: false
  How to use: Setting this flag to true turns off DirectDraw usage, which sometimes helps to get rid of rendering problems on Win32.
• sun.java2d.ddoffscreen: Obsoleted in: Java SE 6 Update 10
  Intended use: To turn on hardware-accelerated scaling when the DirectDraw/Direct3D pipeline is in use.
  Introduced: 1.2
  Default value: false
  How to use: Setting this flag to true enables hardware-accelerated scaling if the DirectDraw/Direct3D pipeline is in use. DirectDraw/Direct3D hardware scaling is disabled by default to avoid rendering artifacts in existing applications. These rendering artifacts are caused by possible inconsistencies between the scale method that the software scaling operation uses (nearest neighbor) and the different scale methods that video cards use. Certain events that occur while an application is running might cause a scaled image to be rendered partially with hardware scaling operations and partially with software scaling operations, resulting in an inconsistent appearance. For now, you can enable acceleration by setting the ddscale flag to true.

Should we:

• Continue supporting these indefinitely, or
• Mark them as deprecated for removal in some upcoming release?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354077: Get rid of offscreenSharingEnabled windows flag (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24534/head:pull/24534
$ git checkout pull/24534

Update a local copy of the PR:
$ git checkout pull/24534
$ git pull https://git.openjdk.org/jdk.git pull/24534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24534

View PR using the GUI difftool:
$ git pr show -t 24534

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24534.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354077: Get rid of offscreenSharingEnabled windows flag

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e14e1d50)
• 00: Full (ad3ac5ca)

[prrace]

This is fine.
But much worse than these being in the code is that we still document them !
https://docs.oracle.com/en/java/javase/17/troubleshoot/java-2d-pipeline-rendering-and-properties.html#GUID-DEA4F3FC-87F5-4196-A295-30A559982B10
I have it on my to-do list to re-write that entire out of date doc.

[mrserb]

/integrate

[openjdk]

Going to push as commit c7c77eb.
Since your change was applied there have been 7 commits pushed to the master branch:

• 4f58af0: 8259540: MissingResourceException for key cvc-complex-type.2.4.d.1
• bd73127: 8354532: Open source JFileChooser Tests - Set 7
• 76dec47: 8354340: Open source Swing Tests - Set 6
• ... and 4 more: https://git.openjdk.org/jdk/compare/924638c471b0bf4a00a890ce6a3fd7e118cdd578...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit c7c77eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.