8354508: JFR: Strengthen metadata checks for labels

[egahlin]

Could I have a review of a PR that improves the checks for label metadata? When running TestEventMetadata, I found some fields with incorrect capitalization. I fixed those, as well as some typos, and updated the filename from trace.xml to metadata.xml.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354508: JFR: Strengthen metadata checks for labels (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24616/head:pull/24616
$ git checkout pull/24616

Update a local copy of the PR:
$ git checkout pull/24616
$ git pull https://git.openjdk.org/jdk.git pull/24616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24616

View PR using the GUI difftool:
$ git pr show -t 24616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24616.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354508: JFR: Strengthen metadata checks for labels

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 51ce312: 8348645: IGV: visualize live ranges
• f8ae1d4: 8354254: Remove the linux ppc64 -minsert-sched-nops=regroup_exact compile flag
• f169fc5: 8353175: Eliminate double iteration of stream in FieldDescriptor reinitialization
• ... and 1 more: https://git.openjdk.org/jdk/compare/44245f33cdc3d6aa1f976205828152487806669d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[shipilev]

Makes sense. Only stylistic nits:

[shipilev]

Looks reasonable to me, thanks.

[mlbridge]

Webrevs

• 00: Full (5dd5653f)

[egahlin]

/integrate

[openjdk]

Going to push as commit d7676c3.
Since your change was applied there have been 23 commits pushed to the master branch:

• 81d4c80: 8354507: [ubsan] subnode.cpp:406:36: runtime error: negation of -9223372036854775808 cannot be represented in type 'long int'
• 24be888: 8351833: Unexpected increase in live nodes when splitting Phis through MergeMems in PhiNode::Ideal
• b783784: 8354163: Open source Swing tests Batch 1
• ... and 20 more: https://git.openjdk.org/jdk/compare/44245f33cdc3d6aa1f976205828152487806669d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit d7676c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.