Skip to content

8354471: Assertion failure with -XX:-EnableX86ECoreOpts #24644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vpaprotsk wants to merge 3 commits into from
Closed

8354471: Assertion failure with -XX:-EnableX86ECoreOpts #24644

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ad246c
Fix ECore check to be same as UseIntPolyIntrinsics
vpaprotsk Apr 15, 2025
ee1b099
flip the direction of if to prefer AVX512
vpaprotsk Apr 15, 2025
60f0032
Update src/hotspot/cpu/x86/stubGenerator_x86_64_poly_mont.cpp
vpaprotsk Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/hotspot/cpu/x86/stubGenerator_x86_64_poly_mont.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,16 @@ address StubGenerator::generate_intpoly_montgomeryMult_P256() {
address start = __ pc();
__ enter();

if (EnableX86ECoreOpts && UseAVX > 1) {
if (VM_Version::supports_avx512ifma() && VM_Version::supports_avx512vlbw()) {
// Register Map
const Register aLimbs = c_rarg0; // rdi | rcx
const Register bLimbs = c_rarg1; // rsi | rdx
const Register rLimbs = c_rarg2; // rdx | r8
const Register tmp = r9;

montgomeryMultiply(aLimbs, bLimbs, rLimbs, tmp, _masm);
} else {
assert(VM_Version::supports_avxifma(), "Require AVX_IFMA support");
__ push(r12);
__ push(r13);
__ push(r14);
Expand Down Expand Up @@ -607,14 +616,6 @@ address StubGenerator::generate_intpoly_montgomeryMult_P256() {
__ pop(r14);
__ pop(r13);
__ pop(r12);
} else {
// Register Map
const Register aLimbs = c_rarg0; // rdi | rcx
const Register bLimbs = c_rarg1; // rsi | rdx
const Register rLimbs = c_rarg2; // rdx | r8
const Register tmp = r9;

montgomeryMultiply(aLimbs, bLimbs, rLimbs, tmp, _masm);
}

__ leave();
Expand Down