8354493: Opensource Several MultiScreen and Insets related tests #24654

kumarabhi006 · 2025-04-15T09:35:27Z

Several multi screen related Applet tests are converted to manual and open sourced.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8354493: Opensource Several MultiScreen and Insets related tests (Bug - P4)

Reviewers

Prasanta Sadhukhan (@prsadhuk - Reviewer)
Tejesh R (@TejeshR13 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24654/head:pull/24654
$ git checkout pull/24654

Update a local copy of the PR:
$ git checkout pull/24654
$ git pull https://git.openjdk.org/jdk.git pull/24654/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24654

View PR using the GUI difftool:
$ git pr show -t 24654

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24654.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-15T09:36:17Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-15T09:37:09Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354493: Opensource Several MultiScreen and Insets related tests

Reviewed-by: psadhukhan, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 443 new commits pushed to the master branch:

055b750: 8354543: Set more meaningful names for "get_vm_result" and "get_vm_result_2"
a71f621: 8353694: Resolved Class/Field/Method CP entries missing from AOT Configuration
07aad68: 8329887: RISC-V: C2: Support Zvbb Vector And-Not instruction
... and 440 more: https://git.openjdk.org/jdk/compare/c2e14b1b304796753bea2eca81aa24ab4b3bf6db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-04-15T09:37:55Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-15T09:41:30Z

Webrevs

TejeshR13 · 2025-04-15T10:50:31Z

test/jdk/java/awt/Multiscreen/DialogTest.java

+        }
+
+        public String toString() {
+            return "Screen " + num + (frameOwned ? " Frame-owned" : " Dialog-owned") + (modal ? " modal " : " non-modal ") +


Column length to be limited to 80.

ky0n · 2025-04-15T20:16:48Z

test/jdk/java/awt/Multiscreen/DialogTest.java

+
+        public Dialog createDialog() {
+            GraphicsConfiguration gc = gds[num].getDefaultConfiguration();
+            String title = toString();


unused, use variable instead of toString() afterwards?

ky0n · 2025-04-15T20:18:49Z

test/jdk/java/awt/Multiscreen/DialogTest.java

+                    ((JDialog) d).getContentPane().add(new JLabel("Check that I am modal!"));
+                }
+            } else {
+                if (frameOwned) {


this code part is in 'if' and 'else' path, can be done before.

No.. there is a difference.
One is for JDialog and other is for Dialog

prsadhuk · 2025-04-16T12:37:01Z

test/jdk/java/awt/Multiscreen/DialogTest.java

+                .instructions(INSTRUCTIONS)
+                .columns(40)
+                .logArea(5)
+                .testUI(obj::init)


No need to create "obj"..we can call DialogTest.init directly..

prsadhuk · 2025-04-16T12:38:38Z

test/jdk/java/awt/Multiscreen/IMCandidateWindowTest.java

+        }
+
+        String INSTRUCTIONS = """
+                Platform: windows


this can be removed or rephrased "This test is for windows"

kumarabhi006 · 2025-04-17T12:30:34Z

/integrate

openjdk · 2025-04-17T12:31:33Z

Going to push as commit e9c8986.
Since your change was applied there have been 451 commits pushed to the master branch:

9502ab0: 8354766: Test TestUnexported.java javac build fails
5125ceb: 8349405: Redundant and confusing null checks on data from CP::resolved_klasses
1138a18: 8344251: C2: remove blackholes with dead control input
... and 448 more: https://git.openjdk.org/jdk/compare/c2e14b1b304796753bea2eca81aa24ab4b3bf6db...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-17T12:31:44Z

@kumarabhi006 Pushed as commit e9c8986.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Applet test converted and open-sourced

264e8bb

openjdk bot added the rfr Pull request is ready for review label Apr 15, 2025

openjdk bot added the client client-libs-dev@openjdk.org label Apr 15, 2025

TejeshR13 reviewed Apr 15, 2025

View reviewed changes

Limit to 80 cols

f16a018

ky0n reviewed Apr 15, 2025

View reviewed changes

Remove unused variable

e07c51a

prsadhuk approved these changes Apr 16, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2025

Minor updates

fd57f44

openjdk bot removed the ready Pull request is ready to be integrated label Apr 17, 2025

prsadhuk approved these changes Apr 17, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2025

TejeshR13 approved these changes Apr 17, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Apr 17, 2025

openjdk bot closed this Apr 17, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2025

8354493: Opensource Several MultiScreen and Insets related tests #24654

8354493: Opensource Several MultiScreen and Insets related tests #24654

Uh oh!

Conversation

kumarabhi006 commented Apr 15, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 15, 2025

Uh oh!

openjdk bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 15, 2025

Uh oh!

mlbridge bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

TejeshR13 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

ky0n Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

ky0n Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

kumarabhi006 commented Apr 15, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Apr 15, 2025 •

edited

Loading

mlbridge bot commented Apr 15, 2025 •

edited

Loading