8353298: AOT cache creation asserts with _array_klasses in an unregistered InstanceKlass

[iklam]

The assert in Klass::remove_java_mirror() is too narrow. When creating the AOT cache, it's possible to see two types of Klasses that do not have a Java mirror:

• Unregistered classes (a cached class to be loaded by a custom class loader in the production run)
• An array type of an unregistered class

I have relaxed the assert to accept both conditions

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353298: AOT cache creation asserts with _array_klasses in an unregistered InstanceKlass (Bug - P3)

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24711/head:pull/24711
$ git checkout pull/24711

Update a local copy of the PR:
$ git checkout pull/24711
$ git pull https://git.openjdk.org/jdk.git pull/24711/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24711

View PR using the GUI difftool:
$ git pr show -t 24711

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24711.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353298: AOT cache creation asserts with _array_klasses in an unregistered InstanceKlass

Reviewed-by: ccheung, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

• 594b265: 8350126: Regression ~3% on Crypto-ChaCha20Poly1305.encrypt for MacOSX aarch64
• d783a94: 8332368: ubsan aarch64: immediate_aarch64.cpp:298:31: runtime error: shift exponent 32 is too large for 32-bit type 'int'
• 6a31061: 8354248: Open source several AWT GridBagLayout and List tests
• ... and 79 more: https://git.openjdk.org/jdk/compare/a71f621a3248320e8a7a78f1652a7750271ed4ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dc58250d)
• 00: Full (79c81bc0)

[calvinccheung]

Looks good. Can you add some comment in the test on what it is testing?

[iklam]

Looks good. Can you add some comment in the test on what it is testing?

I added a @summary section in the test. I intend to add more test cases to this file (e.g., JDK-8354557). That's why I made the name of the test, AOTCacheSupportForCustomLoaders, rather generic.

[calvinccheung]

Looks good.

[vnkozlov]

Good.

[iklam]

Thanks @vnkozlov and @calvinccheung for the review
/integrate

[openjdk]

Going to push as commit 88e0b00.
Since your change was applied there have been 119 commits pushed to the master branch:

• adcaf01: 8355237: Upstream AOT test cases from Leyden repo to mainline
• bf8a881: 8352733: Improve RotFontBoundsTest test
• 3571664: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms
• ... and 116 more: https://git.openjdk.org/jdk/compare/a71f621a3248320e8a7a78f1652a7750271ed4ef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 88e0b00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.