Skip to content

8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX #24963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX #24963

wants to merge 1 commit into from

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 30, 2025 •
edited by openjdk bot
Loading

Seems the currently used ATTRIBUTE_NO_UBSAN does not handle the exclusion of float divisions by zero.
At least this is the case on AIX.

(seen in the jtreg test java/lang/Math/PowTests.java )

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24963/head:pull/24963
$ git checkout pull/24963

Update a local copy of the PR:
$ git checkout pull/24963
$ git pull https://git.openjdk.org/jdk.git pull/24963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24963

View PR using the GUI difftool:
$ git pr show -t 24963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24963.diff

Using Webrev

Link to Webrev Comment

@MBaesken
Copy link
Member Author

/help

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 30, 2025 •
edited
Loading

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX

Reviewed-by: jkern, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX 8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX Apr 30, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 30, 2025
@MBaesken
Copy link
Member Author

/contributor add JoKern65

@openjdk
Copy link

openjdk bot commented Apr 30, 2025

@MBaesken Available commands:

  • approval - request for maintainer's approval
  • approve - null
  • author - sets an overriding author to be used in the commit when the PR is integrated
  • backport - create a backport
  • cc - add or remove an additional classification label
  • clean - Mark the backport pull request as a clean backport
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • jep - require a JDK Enhancement Proposal (JEP) for this pull request
  • label - add or remove an additional classification label
  • open - Set the pull request state to "open"
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

@openjdk
Copy link

openjdk bot commented Apr 30, 2025

@MBaesken JoKern65 was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented Apr 30, 2025

@MBaesken The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 30, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 30, 2025

Webrevs

JoKern65
JoKern65 approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@JoKern65 JoKern65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TheRealMDoerr
TheRealMDoerr reviewed May 2, 2025
View reviewed changes
src/hotspot/share/sanitizers/ub.hpp
#if defined(__clang__)
#define ATTRIBUTE_NO_UBSAN __attribute__((no_sanitize("undefined","float-divide-by-zero")))
#endif
#if defined(__GNUC__) && !defined(__clang__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use #elif?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should I try to set it for BOTH clang and gcc so that the added checks are not needed any more?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change it to #elif, then please do it in both files.

RealLucy
RealLucy approved these changes May 4, 2025
View reviewed changes
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/hotspot/share/sanitizers/ub.hpp
#if defined(__clang__)
#define ATTRIBUTE_NO_UBSAN __attribute__((no_sanitize("undefined","float-divide-by-zero")))
#endif
#if defined(__GNUC__) && !defined(__clang__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change it to #elif, then please do it in both files.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2025
@MBaesken
Copy link
Member Author

MBaesken commented May 6, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2025

Going to push as commit 088825e.
Since your change was applied there have been 84 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2025
@openjdk openjdk bot closed this May 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2025
@openjdk
Copy link

openjdk bot commented May 6, 2025

@MBaesken Pushed as commit 088825e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@TheRealMDoerr TheRealMDoerr TheRealMDoerr left review comments

@RealLucy RealLucy RealLucy approved these changes

@JoKern65 JoKern65 JoKern65 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MBaesken @TheRealMDoerr @RealLucy @JoKern65