8348351: Improve lazy initialization of the available currencies set

[justin-curtis-lu]

Please review this PR which stems from discussion in the PR of JDK-8347949.

The set of lazily loaded Currencies is a good fit for stable values. available can now be made final as it is a SV supplier.

(This change also includes an unrelated minor edit to comments in Currency::getCurrencies to make the distinction for simple vs special Currencies.)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348351: Improve lazy initialization of the available currencies set (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25134/head:pull/25134
$ git checkout pull/25134

Update a local copy of the PR:
$ git checkout pull/25134
$ git pull https://git.openjdk.org/jdk.git pull/25134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25134

View PR using the GUI difftool:
$ git pr show -t 25134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25134.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348351: Improve lazy initialization of the available currencies set

Reviewed-by: liach, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 127 new commits pushed to the master branch:

• 8a8893e: 8356562: SigningAppImageTwoStepsTest test fails
• c2a4fa1: 8355573: Remove kludge_c++11.h from jpackage code
• 4379e2d: 8356125: Interned strings are omitted from AOT cache
• ... and 124 more: https://git.openjdk.org/jdk/compare/394961c8fe87da7376cc7522580cd4ac104c3cf5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e2672ba1)
• 00: Full (f9e9c6b2)

[liach]

I think we should rename this to computeCurrencies or makeCurrencies to indicate we are creating a new instance.

[justin-curtis-lu]

Definitely; updated in e2672ba.

[liach]

Looks great to me. Thanks!

[naotoj]

LGTM

[justin-curtis-lu]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit b6b5ac1.
Since your change was applied there have been 176 commits pushed to the master branch:

• 2595fcc: 8356192: Enable AOT code caching only on supported platforms
• 0f5c608: 8356695: java/lang/StringBuilder/HugeCapacity.java failing with OOME
• 45dfc2c: 8353642: Deprecate URL::getPermission method and networking permission classes for removal
• ... and 173 more: https://git.openjdk.org/jdk/compare/394961c8fe87da7376cc7522580cd4ac104c3cf5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit b6b5ac1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.