Skip to content

8354460: Streaming output for attach API should be turned on by default #25192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexmenkov wants to merge 2 commits into from
Closed

8354460: Streaming output for attach API should be turned on by default #25192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
076e6e8
fix
alexmenkov May 12, 2025
1bda79a
removed comment
alexmenkov Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hotspot/share/services/attachListener.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ volatile AttachListenerState AttachListener::_state = AL_NOT_INITIALIZED;

AttachAPIVersion AttachListener::_supported_version = ATTACH_API_V1;

// Default is false (if jdk.attach.vm.streaming property is not set).
bool AttachListener::_default_streaming_output = false;
// Default is true (if jdk.attach.vm.streaming property is not set).
bool AttachListener::_default_streaming_output = true;

static bool get_bool_sys_prop(const char* name, bool default_value, TRAPS) {
ResourceMark rm(THREAD);
Expand Down
3 changes: 1 addition & 2 deletions src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,8 @@ private static long pid() {
static {
String s = VM.getSavedProperty("jdk.attach.allowAttachSelf");
ALLOW_ATTACH_SELF = "".equals(s) || Boolean.parseBoolean(s);
// For now the default is false.
String s2 = VM.getSavedProperty("jdk.attach.allowStreamingOutput");
ALLOW_STREAMING_OUTPUT = "".equals(s2) || Boolean.parseBoolean(s2);
ALLOW_STREAMING_OUTPUT = !("false".equals(s2));
}

private final boolean selfAttach;
Expand Down