8356820: fixpath should allow + in paths on Windows

[chiroito]

When we run configure on Windows, fixpath is used, but this causes an error if the path contains +.

For example, when we unzip Temurin 24, the directory name created is jdk-24+36. When we specify this as the boot JDK, the following error is output and configure fails

configure: The path of BOOT_JDK_ARG, which is given as “/mnt/d/opt/jdks/temurin-24+36”, cannot be properly resolved.
configure: Please see the section “Special Considerations” in building.md.
configure: This is the error message given by fixpath:
fixpath: failure: Path '/mnt/d/opt/jdks/temurin-24+36' could not be converted to short path
configure: error: Cannot continue

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8356820: fixpath should allow + in paths on Windows

Issue

• JDK-8356820: fixpath should allow + in paths on Windows (Enhancement - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25197/head:pull/25197
$ git checkout pull/25197

Update a local copy of the PR:
$ git checkout pull/25197
$ git pull https://git.openjdk.org/jdk.git pull/25197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25197

View PR using the GUI difftool:
$ git pr show -t 25197

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25197.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cito! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chiroito This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356820: fixpath should allow + in paths on Windows

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• de10644: 8356631: OopHandle replacement methods should not be called on empty handles
• 14d372b: 8356816: JFR: Move printing of metadata into separate class
• d930dc5: 8356275: TestCodeEntryAlignment fails with "Alignment must be <= CodeEntryAlignment"
• ... and 34 more: https://git.openjdk.org/jdk/compare/d7cb933b89839b692f5562aeeb92076cd25a99f6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@chiroito The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a6c58267)

[chiroito]

/integrate

[openjdk]

Going to push as commit 0c4bc48.
Since your change was applied there have been 53 commits pushed to the master branch:

• a96424b: 8356694: Removed unused subclass audits in ObjectInput/OutputStream
• 4c0a0ab: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API
• 10dcdf1: 8347606: Optimize Java implementation of ML-DSA
• ... and 50 more: https://git.openjdk.org/jdk/compare/d7cb933b89839b692f5562aeeb92076cd25a99f6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chiroito Pushed as commit 0c4bc48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[magicus]

@chiroito
Sorry for coming in late here. While this patch works, and solves your immediate problem, I think it opens more questions than it answers. Most pressing of all: why did the conversion to shortpath fail? That is supposed to be a general method to rewrite any "suspicious" path to a format that is guaranteed to work in make with no ill side effects. I believe adding + to the set of allowed characters is benign, but I did initially keep this set small and restricted, and rather convert to shortpath one time too many than to miss some odd characters that will cause trouble later on.

I would like to know more why + failed, and why we don't see any more information about what was problematic. Especially when run after JDK-8244533 was integrated, more information should be given.