Skip to content

8356233: NMT: tty->print_cr should not be used in VirtualMemoryTracker::add_reserved_region() #25308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gerard-ziemski wants to merge 5 commits into from
Closed

8356233: NMT: tty->print_cr should not be used in VirtualMemoryTracker::add_reserved_region() #25308

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a993083
convert to UL
gerard-ziemski May 19, 2025
e7e87fe
revert header change
gerard-ziemski May 19, 2025
b32dbbe
revert debug change
gerard-ziemski May 19, 2025
985856e
Johan's feedback
gerard-ziemski May 20, 2025
5b0e0f5
Merge remote-tracking branch 'upstream/master' into JDK-8356233
gerard-ziemski May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/hotspot/share/nmt/virtualMemoryTracker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,17 +401,20 @@ bool VirtualMemoryTracker::add_reserved_region(address base_addr, size_t size,
return true;
}

// Print some more details. Don't use UL here to avoid circularities.
tty->print_cr("Error: existing region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %u.\n"
" new region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %u.",
p2i(reserved_rgn->base()), p2i(reserved_rgn->end()), (unsigned)reserved_rgn->mem_tag(),
p2i(base_addr), p2i(base_addr + size), (unsigned)mem_tag);
// Print some more details.
stringStream ss;
ss.print_cr("Error: old region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %s.\n"
" new region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %s.",
p2i(reserved_rgn->base()), p2i(reserved_rgn->end()), NMTUtil::tag_to_name(reserved_rgn->mem_tag()),
p2i(base_addr), p2i(base_addr + size), NMTUtil::tag_to_name(mem_tag));
if (MemTracker::tracking_level() == NMT_detail) {
tty->print_cr("Existing region allocated from:");
reserved_rgn->call_stack()->print_on(tty);
tty->print_cr("New region allocated from:");
stack.print_on(tty);
ss.print_cr("Existing region allocated from:");
reserved_rgn->call_stack()->print_on(&ss);
ss.print_cr("New region allocated from:");
stack.print_on(&ss);
}
log_debug(nmt)("%s", ss.freeze());

ShouldNotReachHere();
return false;
}
Expand Down