Skip to content

8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter #25393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chhagedorn wants to merge 3 commits into from
Closed

8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter #25393

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1de489e
8357568: IGV: Show NULL and numbers up to 4 characters in "Condense g…
chhagedorn May 22, 2025
4f77d00
Increase number of parameters as suggested by Manuel
chhagedorn May 22, 2025
c4381a0
better way to check nof chars, also print narrow oop null
chhagedorn May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/hotspot/share/opto/idealGraphPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,12 +626,8 @@ void IdealGraphPrinter::visit_node(Node* n, bool edges) {
const char *short_name = "short_name";
if (strcmp(node->Name(), "Parm") == 0 && node->as_Proj()->_con >= TypeFunc::Parms) {
int index = node->as_Proj()->_con - TypeFunc::Parms;
if (index >= 10) {
print_prop(short_name, "PA");
} else {
os::snprintf_checked(buffer, sizeof(buffer), "P%d", index);
print_prop(short_name, buffer);
}
os::snprintf_checked(buffer, sizeof(buffer), "P%d", index);
print_prop(short_name, buffer);
} else if (strcmp(node->Name(), "IfTrue") == 0) {
print_prop(short_name, "T");
} else if (strcmp(node->Name(), "IfFalse") == 0) {
Expand All @@ -643,9 +639,9 @@ void IdealGraphPrinter::visit_node(Node* n, bool edges) {
assert(typeInt->is_con(), "must be constant");
jint value = typeInt->get_con();

// max. 2 chars allowed
if (value >= -9 && value <= 99) {
os::snprintf_checked(buffer, sizeof(buffer), "%d", value);
// Only use up to 4 chars and fall back to a generic "I" to keep it short.
int written_chars = os::snprintf_checked(buffer, sizeof(buffer), "%d", value);
if (written_chars <= 4) {
print_prop(short_name, buffer);
} else {
print_prop(short_name, "I");
Expand All @@ -657,9 +653,9 @@ void IdealGraphPrinter::visit_node(Node* n, bool edges) {
assert(typeLong->is_con(), "must be constant");
jlong value = typeLong->get_con();

// max. 2 chars allowed
if (value >= -9 && value <= 99) {
os::snprintf_checked(buffer, sizeof(buffer), JLONG_FORMAT, value);
// Only use up to 4 chars and fall back to a generic "L" to keep it short.
int written_chars = os::snprintf_checked(buffer, sizeof(buffer), JLONG_FORMAT, value);
if (written_chars <= 4) {
print_prop(short_name, buffer);
} else {
print_prop(short_name, "L");
Expand All @@ -676,11 +672,17 @@ void IdealGraphPrinter::visit_node(Node* n, bool edges) {
} else if (t->base() == Type::Return_Address) {
print_prop(short_name, "RA");
} else if (t->base() == Type::AnyPtr) {
print_prop(short_name, "P");
if (t->is_ptr()->ptr() == TypePtr::Null) {
print_prop(short_name, "Null");
} else {
print_prop(short_name, "P");
}
} else if (t->base() == Type::RawPtr) {
print_prop(short_name, "RP");
} else if (t->base() == Type::AryPtr) {
print_prop(short_name, "AP");
} else if (t->base() == Type::NarrowOop && t->is_narrowoop() == TypeNarrowOop::NULL_PTR) {
print_prop(short_name, "Null");
}
}

Expand Down