-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8357797: Use StructuredTaskScopeImpl.ST_NEW for state init #25452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
src/java.base/share/classes/java/util/concurrent/StructuredTaskScopeImpl.java
Show resolved
Hide resolved
|
Looks simple enough to me, and unlikely to cause conflicts/problems, so I am integrating now. /integrate |
|
Going to push as commit b9db99d.
Your commit was automatically rebased without conflicts. |
SonarCloud complains
ST_NEWconstant is not used. Looks to me the constructor implicitly relies on default value forstate. It would be cleaner to initialize it explicitlyAdditional testing:
java/util/concurrentProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25452/head:pull/25452$ git checkout pull/25452Update a local copy of the PR:
$ git checkout pull/25452$ git pull https://git.openjdk.org/jdk.git pull/25452/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25452View PR using the GUI difftool:
$ git pr show -t 25452Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25452.diff
Using Webrev
Link to Webrev Comment