8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent

[robehn]

Hi please consider.

As ref: #25483
As suggested in that PR - I removed these helpers as it's very hard to see that you get registers clobbered.

Sanity tested, running t1.

/Robbin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent (Bug - P4)

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Fredrik Bredberg (@fbredber - Committer)
• Aleksey Shipilev (@shipilev - Reviewer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25502/head:pull/25502
$ git checkout pull/25502

Update a local copy of the PR:
$ git checkout pull/25502
$ git pull https://git.openjdk.org/jdk.git pull/25502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25502

View PR using the GUI difftool:
$ git pr show -t 25502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25502.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent

Reviewed-by: eosterlund, fbredberg, shade, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 83a2804: 8357408: runtime/interpreter/CountBytecodesTest.java should be flagless
• 2ec6ab3: 8357525: Default CDS archive becomes non-deterministic after JDK-8305895
• dede353: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics
• ... and 22 more: https://git.openjdk.org/jdk/compare/39714b603040f1619f5e0e2a13ea8a90bb993c27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@robehn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d8fbf29a)

[fisk]

Great stuff. Thanks for fixing.

[fbredber]

Looks good to me.

[RealFYang]

Thanks! I performed hs:tier1-hs:tier3 test on SG2042 platform. Result looks good.

[robehn]

Thanks all!

[robehn]

/integrate

[openjdk]

Going to push as commit c5a1543.
Since your change was applied there have been 84 commits pushed to the master branch:

• 90d6ad0: 8356594: JSplitPane loses divider location when reopened via JOptionPane.createDialog()
• 3193a28: 8358259: ProblemList compiler/startup/StartupOutput.java on Windows
• 85e36d7: 8358236: [AOT] Graal crashes when trying to use persisted MDOs
• ... and 81 more: https://git.openjdk.org/jdk/compare/39714b603040f1619f5e0e2a13ea8a90bb993c27...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit c5a1543.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.