8356634: VectorShape#largestShapeFor should have public access

[igraves]

VectorShape#largestShapeFor is referenced in existing JavaDoc but has been package-private. This propose change makes it public and adds documentation for it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8358009 to be approved

Issues

• JDK-8356634: VectorShape#largestShapeFor should have public access (Sub-task - P4)
• JDK-8358009: VectorShape#largestShapeFor should have public access (CSR)

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25513/head:pull/25513
$ git checkout pull/25513

Update a local copy of the PR:
$ git checkout pull/25513
$ git pull https://git.openjdk.org/jdk.git pull/25513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25513

View PR using the GUI difftool:
$ git pr show -t 25513

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25513.diff

Using Webrev

Link to Webrev Comment

[igraves]

/csr

[bridgekeeper]

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356634: VectorShape#largestShapeFor should have public access

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• abbffc0: 8358202: ProblemList vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java
• 14e41ab: 8357172: Extend try block in nsk/jdi tests to capture exceptions thrown by Debuggee.classByName()
• c9d6e01: 8358076: KeyFactory.getInstance("EdDSA").generatePublic(null) throws NPE
• ... and 38 more: https://git.openjdk.org/jdk/compare/bb2c80c0e9923385e0b6243c0ebff9afef208470...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@igraves an approved CSR request is already required for this pull request.

[openjdk]

@igraves To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[igraves]

/label core-libs

[openjdk]

@igraves
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 04: Full - Incremental (90066a23)
• 03: Full - Incremental (097bd9dd)
• 02: Full - Incremental (8b3f6fc4)
• 01: Full - Incremental (a00420b2)
• 00: Full (1e59fcab)

[PaulSandoz]

Can you add something to the method testVectorShape in test/jdk/jdk/incubator/vector/PreferredSpeciesTest.java?

[igraves]

Added test coverage for this method based on its codepath and the *MaxVector shape path for consistency.

[igraves]

/integrate

[openjdk]

Going to push as commit 09301c1.
Since your change was applied there have been 41 commits pushed to the master branch:

• abbffc0: 8358202: ProblemList vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java
• 14e41ab: 8357172: Extend try block in nsk/jdi tests to capture exceptions thrown by Debuggee.classByName()
• c9d6e01: 8358076: KeyFactory.getInstance("EdDSA").generatePublic(null) throws NPE
• ... and 38 more: https://git.openjdk.org/jdk/compare/bb2c80c0e9923385e0b6243c0ebff9afef208470...master

Your commit was automatically rebased without conflicts.

[openjdk]

@igraves Pushed as commit 09301c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.