8358105: RISC-V: Optimize interpreter profile updates

[Anjian-Wen]

The reason of this patch is same as the x86 and aarch64 but for riscv
JDK-8356946
JDK-8357223

First, we carry the implementation for counter decrements without using them. This is dead code, and can be purged. Second, we care about overflows for 64-bit for some reason. I think this is a reminiscent of 32-bit x86 support, where we can plausibly have 32-bit counter overflow in a reasonable timeframe. But for 64-bit counter, we need tens of years of constantly bashing the counter to get it to overflow. No other profile counter update code, e.g. in C1, cares about this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358105: RISC-V: Optimize interpreter profile updates (Enhancement - P4)

Reviewers

• Feilong Jiang (@feilongjiang - Committer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25520/head:pull/25520
$ git checkout pull/25520

Update a local copy of the PR:
$ git checkout pull/25520
$ git pull https://git.openjdk.org/jdk.git pull/25520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25520

View PR using the GUI difftool:
$ git pr show -t 25520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25520.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wenanjian! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Anjian-Wen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358105: RISC-V: Optimize interpreter profile updates

Reviewed-by: fjiang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

• 2345065: 8357600: Patch nmethod flushing message to include more details
• 9c74d54: 8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException
• 9397535: 8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance
• ... and 118 more: https://git.openjdk.org/jdk/compare/a2743bab4fd203b0791cf47e617c1a95b05ab3cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@feilongjiang, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@Anjian-Wen The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[Anjian-Wen]

/issue JDK-8358105

[openjdk]

@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[mlbridge]

Webrevs

• 00: Full (3dcba0d2)

[feilongjiang]

Looks good!

[RealFYang]

Thanks. My local tier1-2 test on linux-riscv64 is clean.

[Anjian-Wen]

@feilongjiang @RealFYang Thanks for your review and comments！

[Anjian-Wen]

/integrate

[openjdk]

@Anjian-Wen
Your change (at version 3dcba0d) is now ready to be sponsored by a Committer.

[feilongjiang]

/sponsor

[openjdk]

Going to push as commit 939521b.
Since your change was applied there have been 121 commits pushed to the master branch:

• 2345065: 8357600: Patch nmethod flushing message to include more details
• 9c74d54: 8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException
• 9397535: 8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance
• ... and 118 more: https://git.openjdk.org/jdk/compare/a2743bab4fd203b0791cf47e617c1a95b05ab3cc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@feilongjiang @Anjian-Wen Pushed as commit 939521b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.