Skip to content

Conversation

@ascarpino
Copy link
Contributor

@ascarpino ascarpino commented Jun 3, 2025

Hi, I need a review of some PEM updates. PEMRecord.pem is renamed to content to better describe that it is the base64 content and not including the header and footer. Additionally, PEMRecord.getEncoded() is removed and some javadoc clarifications for PEMEncoder and PEMDecoder. Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8358100 to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25620/head:pull/25620
$ git checkout pull/25620

Update a local copy of the PR:
$ git checkout pull/25620
$ git pull https://git.openjdk.org/jdk.git pull/25620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25620

View PR using the GUI difftool:
$ git pr show -t 25620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25620.diff

Using Webrev

Link to Webrev Comment

@ascarpino ascarpino marked this pull request as ready for review June 3, 2025 16:10
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2025

👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@ascarpino This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358099: PEM spec updates

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 3, 2025
@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@ascarpino The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 3, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2025

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 5, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 5, 2025
@ascarpino
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

Going to push as commit 78158f3.
Since your change was applied there have been 76 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2025
@openjdk openjdk bot closed this Jun 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@ascarpino Pushed as commit 78158f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ascarpino
Copy link
Contributor Author

/backport :jdk25

1 similar comment
@ascarpino
Copy link
Contributor Author

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@ascarpino the backport was successfully created on the branch backport-ascarpino-78158f30-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 78158f30 from the openjdk/jdk repository.

The commit being backported was authored by Anthony Scarpino on 5 Jun 2025 and was reviewed by Sean Mullan.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-ascarpino-78158f30-jdk25:backport-ascarpino-78158f30-jdk25
$ git checkout backport-ascarpino-78158f30-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-ascarpino-78158f30-jdk25

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@ascarpino the backport was successfully created on the branch backport-ascarpino-78158f30-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 78158f30 from the openjdk/jdk repository.

The commit being backported was authored by Anthony Scarpino on 5 Jun 2025 and was reviewed by Sean Mullan.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-ascarpino-78158f30-jdk25:backport-ascarpino-78158f30-jdk25
$ git checkout backport-ascarpino-78158f30-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-ascarpino-78158f30-jdk25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants