-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8358099: PEM spec updates #25620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8358099: PEM spec updates #25620
Conversation
|
👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into |
|
@ascarpino This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 72 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@ascarpino The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
/integrate |
|
Going to push as commit 78158f3.
Your commit was automatically rebased without conflicts. |
|
@ascarpino Pushed as commit 78158f3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport :jdk25 |
1 similar comment
|
/backport :jdk25 |
|
@ascarpino the backport was successfully created on the branch backport-ascarpino-78158f30-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
|
@ascarpino the backport was successfully created on the branch backport-ascarpino-78158f30-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
Hi, I need a review of some PEM updates.
PEMRecord.pemis renamed tocontentto better describe that it is the base64 content and not including the header and footer. Additionally,PEMRecord.getEncoded()is removed and some javadoc clarifications for PEMEncoder and PEMDecoder. Thanks.Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25620/head:pull/25620$ git checkout pull/25620Update a local copy of the PR:
$ git checkout pull/25620$ git pull https://git.openjdk.org/jdk.git pull/25620/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25620View PR using the GUI difftool:
$ git pr show -t 25620Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25620.diff
Using Webrev
Link to Webrev Comment