Skip to content

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Jun 6, 2025

Use a link of the form System##stdin.encoding to link directly to the system property's description.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358809: Improve link to stdin.encoding from java.lang.IO (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25676/head:pull/25676
$ git checkout pull/25676

Update a local copy of the PR:
$ git checkout pull/25676
$ git pull https://git.openjdk.org/jdk.git pull/25676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25676

View PR using the GUI difftool:
$ git pr show -t 25676

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25676.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2025

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358809: Improve link to stdin.encoding from java.lang.IO

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 6, 2025
@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 6, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2025
@stuart-marks stuart-marks changed the title 8358809: better link to stdin.encoding from java.lang.IO 8358809: Improve link to stdin.encoding from java.lang.IO Jun 6, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Jun 6, 2025
@stuart-marks
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

Going to push as commit d024f58.
Since your change was applied there have been 63 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2025
@openjdk openjdk bot closed this Jun 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2025
@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@stuart-marks Pushed as commit d024f58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stuart-marks
Copy link
Member Author

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@stuart-marks the backport was successfully created on the branch backport-stuart-marks-d024f58e-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d024f58e from the openjdk/jdk repository.

The commit being backported was authored by Stuart Marks on 6 Jun 2025 and was reviewed by Naoto Sato.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-stuart-marks-d024f58e-jdk25:backport-stuart-marks-d024f58e-jdk25
$ git checkout backport-stuart-marks-d024f58e-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-stuart-marks-d024f58e-jdk25

⚠️ @stuart-marks You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants