8359364: java/net/URL/EarlyOrDelayedParsing test fails intermittently

[dfuch]

Like java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java, the test java/net/URL/EarlyOrDelayedParsing doesn't expect proxies, and may fail if a proxy is selected.

The test sets system properties and runs in otrhervm. The fix is to set up a default ProxySelector that will always return NO_PROXY.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359364: java/net/URL/EarlyOrDelayedParsing test fails intermittently (Bug - P4)

Reviewers

• Volkan Yazici (@vy - Committer)
• SendaoYan (@sendaoYan - Committer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25783/head:pull/25783
$ git checkout pull/25783

Update a local copy of the PR:
$ git checkout pull/25783
$ git pull https://git.openjdk.org/jdk.git pull/25783/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25783

View PR using the GUI difftool:
$ git pr show -t 25783

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25783.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359364: java/net/URL/EarlyOrDelayedParsing test fails intermittently

Reviewed-by: vyazici, syan, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• b4c4496: 8354196: C2: reorder and capitalize phase definition
• b5334fe: 8314180: Disable XPath in XML Signatures
• e8ef93a: 8357782: JVM JIT Causes Static Initialization Order Issue
• ... and 20 more: https://git.openjdk.org/jdk/compare/1fcede053cca360c96606c1034b2a365a4fada82...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (30b6b0d7)
• 00: Full (2bb86456)

[vy]

Copyright year needs to be updated.

[dfuch]

Done

[dfuch]

/integrate

[jaikiran]

This looks fine to me. Although there's a test @run which is not othervm, setting this default ProxySelector (and not resetting it back) should be fine since jdk.net.url.delayParsing by default is false and we don't set the ProxySelector in those cases.

[openjdk]

Going to push as commit 57cabc6.
Since your change was applied there have been 23 commits pushed to the master branch:

• b4c4496: 8354196: C2: reorder and capitalize phase definition
• b5334fe: 8314180: Disable XPath in XML Signatures
• e8ef93a: 8357782: JVM JIT Causes Static Initialization Order Issue
• ... and 20 more: https://git.openjdk.org/jdk/compare/1fcede053cca360c96606c1034b2a365a4fada82...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 57cabc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.