8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java

[justin-curtis-lu]

Please review this PR which removes an incorrect localization test case in sun/security/tools/keytool/i18n.java. The manual test was identified to not emit any localized output for an incorrect keystore password via "-storepass". However, this message is not localized and there are no plans to localize it.

The test should be updated to remove this test case.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25989/head:pull/25989
$ git checkout pull/25989

Update a local copy of the PR:
$ git checkout pull/25989
$ git pull https://git.openjdk.org/jdk.git pull/25989/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25989

View PR using the GUI difftool:
$ git pr show -t 25989

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25989.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java

Reviewed-by: weijun, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 314 new commits pushed to the master branch:

• eceb3bb: 8362452: [macOS] Remove CPrinterJob.finalize()
• 3acdba3: 8362557: [macOS] Remove CFont.finalize()
• 523993e: 8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java
• ... and 311 more: https://git.openjdk.org/jdk/compare/744727647564ee79349380eb819fefc81ca7dc3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c47a428e)
• 00: Full (48ab4255)

[rhalade]

instead, please use 8360400 bug id in bug list. It is closed as won't fix for which test is being updated. We prefer not to use test bugs in this list.

[justin-curtis-lu]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit 5540a78.
Since your change was applied there have been 326 commits pushed to the master branch:

• aae9902: 8360555: Archive all unnamed modules in CDS full module graph
• ea6674f: 8315131: Clarify VarHandle set/get access on 32-bit platforms
• d714b5d: 8356557: Update CodeSource::implies API documentation and deprecate java.net.SocketPermission class for removal
• ... and 323 more: https://git.openjdk.org/jdk/compare/744727647564ee79349380eb819fefc81ca7dc3a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit 5540a78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.