8372307: Clean up the leftover code comment references to file.encoding in java_props_md.c

[hextriclosan]

The file.encoding system property is no longer used by the JDK.
Updated code comments to reference the correct replacement: native.encoding.

/trivial

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372307: Clean up the leftover code comment references to file.encoding in java_props_md.c (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27004/head:pull/27004
$ git checkout pull/27004

Update a local copy of the PR:
$ git checkout pull/27004
$ git pull https://git.openjdk.org/jdk.git pull/27004/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27004

View PR using the GUI difftool:
$ git pr show -t 27004

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27004.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @hextriclosan, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user hextriclosan" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@hextriclosan Unknown command trivial - for a list of valid commands use /help.

[openjdk]

@hextriclosan The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[hextriclosan]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[hextriclosan]

/help

[openjdk]

@hextriclosan Available commands:

• approval - request for maintainer's approval
• approve - null
• author - sets an overriding author to be used in the commit when the PR is integrated
• backport - create a backport
• cc - add or remove an additional classification label
• clean - Mark the backport pull request as a clean backport
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• jep - require a JDK Enhancement Proposal (JEP) for this pull request
• keepalive - Re-evaluates the pull request and resets the inactivity timeout.
• label - add or remove an additional classification label
• open - Set the pull request state to "open"
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests
• touch - Re-evaluates the pull request and resets the inactivity timeout.

[bridgekeeper]

@hextriclosan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[hextriclosan]

/touch

[openjdk]

@hextriclosan The pull request is being re-evaluated and the inactivity timeout has been reset.

[hextriclosan]

/touch

[openjdk]

@hextriclosan The pull request is being re-evaluated and the inactivity timeout has been reset.

[hextriclosan]

/signed

[bridgekeeper]

Already processed the signed command

[hextriclosan]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[hextriclosan]

/sponsor

[openjdk]

@hextriclosan Only Committers are allowed to sponsor changes.

[hextriclosan]

/approval

[openjdk]

@hextriclosan Changes in this repository do not require maintainer approval.

[hextriclosan]

/touch

[openjdk]

@hextriclosan The pull request is being re-evaluated and the inactivity timeout has been reset.

[jaikiran]

Hello Igor @hextriclosan, I have created a JBS issue to address this https://bugs.openjdk.org/browse/JDK-8372307. Please update the title of your PR to 8372307: Clean up the leftover code comment references to file.encoding in java_props_md.c so that it initiates the formal review process of this change.

[hextriclosan]

/touch

[openjdk]

@hextriclosan The pull request is being re-evaluated and the inactivity timeout has been reset.

[mlbridge]

Webrevs

• 00: Full (d25c23cc)

[hextriclosan]

@jaikiran
Done, thank you for your help

[hextriclosan]

/integrate

[openjdk]

@hextriclosan This pull request has not yet been marked as ready for integration.

[RogerRiggs]

You may find it useful to read the OpenJDK Developers Guide.