-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8366951: Test runtime/logging/StressAsyncUL.java is timing out #27195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into |
|
@jdksjolen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@jdksjolen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; I also wonder if trace-level log can be reduced a bit -- the current amount is not very usable, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix. There's always a risk that "all" logging will reach a point where we get swamped with output, and that happened with AOT trace level.
|
thanks! /integrate |
|
Going to push as commit 8ba0db0.
Your commit was automatically rebased without conflicts. |
|
@jdksjolen Pushed as commit 8ba0db0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
This test times out sometimes. This has been known to be caused previously by a resource-constrained execution environment. It may also be because of a race between async logging initialization and the loggers (see JDK-8362282).
This PR reduces the stress by changing the log level from
tracetodebug. This changes the amount of logging from 48M to 6.6M, a significant reduction.The goal with the test was to find out if there are any bugs in the stalling mode by running it in a 'stressful' situation over a long time. The stalling mode was integrated in 2025-02-26 (see #22770 ). I therefore believe that relaxing this test is in our interest, as it reduces the stress on our CICD infra.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27195/head:pull/27195$ git checkout pull/27195Update a local copy of the PR:
$ git checkout pull/27195$ git pull https://git.openjdk.org/jdk.git pull/27195/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27195View PR using the GUI difftool:
$ git pr show -t 27195Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27195.diff
Using Webrev
Link to Webrev Comment