Skip to content

Conversation

@jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Sep 10, 2025

Hi,

This test times out sometimes. This has been known to be caused previously by a resource-constrained execution environment. It may also be because of a race between async logging initialization and the loggers (see JDK-8362282).

This PR reduces the stress by changing the log level from trace to debug. This changes the amount of logging from 48M to 6.6M, a significant reduction.

The goal with the test was to find out if there are any bugs in the stalling mode by running it in a 'stressful' situation over a long time. The stalling mode was integrated in 2025-02-26 (see #22770 ). I therefore believe that relaxing this test is in our interest, as it reduces the stress on our CICD infra.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366951: Test runtime/logging/StressAsyncUL.java is timing out (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27195/head:pull/27195
$ git checkout pull/27195

Update a local copy of the PR:
$ git checkout pull/27195
$ git pull https://git.openjdk.org/jdk.git pull/27195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27195

View PR using the GUI difftool:
$ git pr show -t 27195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27195.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2025

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2025

@jdksjolen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366951: Test runtime/logging/StressAsyncUL.java is timing out

Reviewed-by: ayang, lkorinth, dholmes, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8366951 8366951: Test runtime/logging/StressAsyncUL.java is timing out Sep 10, 2025
@openjdk
Copy link

openjdk bot commented Sep 10, 2025

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review labels Sep 10, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2025

Webrevs

Copy link
Member

@albertnetymk albertnetymk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; I also wonder if trace-level log can be reduced a bit -- the current amount is not very usable, IMO.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 10, 2025
Copy link
Contributor

@lkorinth lkorinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. There's always a risk that "all" logging will reach a point where we get swamped with output, and that happened with AOT trace level.

@jdksjolen
Copy link
Contributor Author

thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

Going to push as commit 8ba0db0.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2025
@openjdk openjdk bot closed this Sep 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@jdksjolen Pushed as commit 8ba0db0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants