8367859: Remove nio exception gensrc

[magicus]

An alternative implementation to #27338, which removes the entire gensrc stage and instead permanently checks in the generated Java files.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8367859: Remove nio exception gensrc (Enhancement - P3)

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27352/head:pull/27352
$ git checkout pull/27352

Update a local copy of the PR:
$ git checkout pull/27352
$ git pull https://git.openjdk.org/jdk.git pull/27352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27352

View PR using the GUI difftool:
$ git pr show -t 27352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27352.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367859: Remove nio exception gensrc

Reviewed-by: naoto, erikj, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 000569d: 8362561: Remove diagnostic option AllowArchivingWithJavaAgent
• c597384: 8367708: GenShen: Reduce total evacuation burden
• b8f2c73: 8367614: Test vmTestbase/nsk/jdi/stress/serial/heapwalking001/TestDescription.java failed, passed and timed-out
• ... and 18 more: https://git.openjdk.org/jdk/compare/01d7554b87fb7be8cab5dc12fd67eaba6585d2f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@magicus The following labels will be automatically applied to this pull request:

• build
• core-libs
• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c6708355)

[AlanBateman]

Can you confirm that tier1 + tier2 are passing? (most of the tests are in tier2).

[naotoj]

charset package changes look good to me

[naotoj]

Could utilize new construct as {@linkplain Charset##names legal charset name}

[AlanBateman]

I assume Magnus is using the generated classes and I think best to not change anything else with this update. We can follow-up yesterday for "opportunities" to modernize.

[naotoj]

OK fair enough. I just noticed that the file was modified, ie.

// -- This file was mechanically generated: Do not edit! -- //

was removed, so.

[AlanBateman]

Yes, I think that has to be removed.

[magicus]

Alan is right, I just copied in the generated files. This is the files as generated by my previous PR. See this comment #27338 (comment) for details on how they differ. (Apart from a bug fix it is whitespace and comments only).

In addition to this, jcheck complained about the generated files containing tabs, so I also had to replace those with spaces.

Please go ahead and modernize the code after this PR. :) (But how to do it "yesterday" eludes me ;-))

[naotoj]

/reviewers 2

[openjdk]

@naotoj
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[bplb]

Looks all right.

[magicus]

Can you confirm that tier1 + tier2 are passing? (most of the tests are in tier2).

Yes, they pass with flying colors.

[magicus]

/integrate

[openjdk]

Going to push as commit 65aea48.
Since your change was applied there have been 35 commits pushed to the master branch:

• 94a301a: 8366875: CompileTaskTimeout should be reset for each iteration of RepeatCompilation
• 937e19e: 8366780: Enhance ProcSmapsParser and Printer to handle THPeligible field
• 930d724: 8367983: javax/management/monitor/ThreadPoolTest.java and StartStopTest.java fail with Unexpected Maximum Pool Size Overflow!
• ... and 32 more: https://git.openjdk.org/jdk/compare/01d7554b87fb7be8cab5dc12fd67eaba6585d2f3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 65aea48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.