8333727: Use JOpt in jpackage to parse command line

[alexeysemenyukoracle]

Use "JOpt Simple" from jdk.internal.joptsimple package to parse jpackage command line.

All command-line parsing code is placed in a new "jdk.jpackage.internal.cli" package with 92% unit test coverage.

Error reporting improved

1. More than one command-line errors are reported.

Command line (Windows):

jpackage --linux-shortcut --mac-package-name foo -p m1 --linux-menu-group grp -p m2 --app-image dir

Old error output:

Error: Option [--linux-shortcut] is not valid on this platform

New error output:

Error: Option [--linux-shortcut] is not valid on this platform
Error: Option [--mac-package-name] is not valid on this platform
Error: Option [-p] is not valid with type [exe]
Error: Option [--linux-menu-group] is not valid on this platform

Help output fixed

Options in the original help output were out of order. On macOS, options were placed in wrong sections. There were trailing whitespaces.

The old help output is captured in the 3ed5383 commit.

The reordered and filtered old help output is captured in the 1a5874c commit.

Help output in this PR is captured in the 2237322 commit. Use it to see the diff between the new and old filtered and reordered help output.

Functional changes

Old tool provider implementation jdk.jpackage.internal.JPackageToolProvider had lousy thread-safety protection that didn't work when multiple instances of jpackage tool provider are created and invoked asynchronously. This patch fixes this issue. It is safe to invoke the same jpackage tool provider instance asynchronously, and also safe to invoke multiple instances of jpackage tool provider.

Like other JDK tools, jpackage will print help output if the -? option is specified on the command line.

In addition to --option-name <value> variant to set option value, supports --option-name=<value>, -option-name=<value>, -option-name <value> variants - courtesy of jdk.internal.joptsimple package.

Misc

All "params"-specific code removed.

The format of the .jpackage.xml file has changed:

• The name of the main launcher is stored as the @name attribute of the /jpackage-state/main-launcher element.
• Child elements of the /jpackage-state element with the values of the main launcher properties are stored as child elements of the /jpackage-state/main-launcher element.
• "launcher-as-service" property of an additional launcher is stored as a text value of the /jpackage-state/add-launcher/service element instead of the value of the /jpackage-state/add-launcher/@service attribute.

Changes to the format of the .jpackage.xml file are to simplify handling of properties of additional and the main launcher.

Autogenerated summary of all recognized options (jdk/test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/cli/jpackage-options.md).

Testing

The same testing as in the #19668 PR. Additionally, verified no unexpected diffs in the test logs after running all jpackage tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333727: Use JOpt in jpackage to parse command line (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27564/head:pull/27564
$ git checkout pull/27564

Update a local copy of the PR:
$ git checkout pull/27564
$ git pull https://git.openjdk.org/jdk.git pull/27564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27564

View PR using the GUI difftool:
$ git pr show -t 27564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27564.diff

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[alexeysemenyukoracle]

@turbanoff thank you for the review. I'll go ahead and apply all your suggested fixes.

Heads up: this PR is still a draft (I accidentally moved it out of this state), it is not yet 100% ready for review.

[openjdk]

@alexeysemenyukoracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout app-pkg-same-app-image-layout+JDK-8333727-merge
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push