Skip to content

Conversation

DarraghClarke
Copy link
Contributor

@DarraghClarke DarraghClarke commented Oct 1, 2025

This PR is based on #25546 , though it was suggested to split that PR into 2 for easier reviewing and to give better visibility in the git history.
This PR contains all the JExtract generated code that will be needed for converting Java's KQueue implementation to use Panama features instead of JNI. The actual updates to KQueue to make use of these files will come in the second PR.

The basic structure here has the different native structures and methods split into 3 different packages all preceded by
src/java.base/macosx/classes/jdk/internal/ffi/generated/
Included in each package is a file package-info.java which contains the script that was used to generate these files so that others can reproduce them in future.

The only modifications that have been made to the files post-generation are:

  • Adding copyright headers
  • Adding warning suppression for using restricted methods

Some further modifications to these files to cut down on code duplication and adding support for errno handling on the native calls will come in the 2nd PR alongside the KQueue changes mentioned.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368877: Generate Jextract bindings for Kqueue (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27590/head:pull/27590
$ git checkout pull/27590

Update a local copy of the PR:
$ git checkout pull/27590
$ git pull https://git.openjdk.org/jdk.git pull/27590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27590

View PR using the GUI difftool:
$ git pr show -t 27590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27590.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2025

👋 Welcome back dclarke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@DarraghClarke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368877: Generate Jextract bindings for Kqueue

Reviewed-by: alanb, aefimov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 249 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@DarraghClarke The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, it gives a baseline for the follow-on changes so it's clear what is modified. The package name looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 2, 2025
* echo "#include <sys/event.h>" >> $HEADER_NAME
*
*
* jextract --target-package jdk.internal.natives.net.kqueue \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the target package be jdk.internal.ffi.generated.kqueue?

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 6, 2025
Copy link
Member

@AlekseiEfimov AlekseiEfimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2025
@DarraghClarke
Copy link
Contributor Author

/Integrate

@DarraghClarke
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2025

Going to push as commit 0db4702.
Since your change was applied there have been 260 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2025
@openjdk openjdk bot closed this Oct 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2025
@openjdk
Copy link

openjdk bot commented Oct 13, 2025

@DarraghClarke Pushed as commit 0db4702.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants