Skip to content

Conversation

@LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Oct 8, 2025

This PR adds support for the upcoming JDBC 4.5 MR which provides the following updates to the JDBC specification:

  • Deprecate SQLPermission for removal
  • Enhance the Blob/Clob/Array/SQLXML/NClob interfaces to extend/support AutoClosable
  • Add the SQL types DECFLOAT, JSON to Types.Java and JDBCType.java
  • Add the quoted identifier methods that were added previously to the Statement interface in JDK 9 to the Connection interface
    • It is the exact same verbiage & default methods used when these methods were added to the Statement interface
  • Clarify the Timestamp::hashCode method which incorrectly indicates that nanos are not used when calculating the hash

Tiers 1-3 have been run


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8369918 to be approved

Issues

  • JDK-8369432: Add Support for JDBC 4.5 MR (Enhancement - P4)
  • JDK-8369918: Add Support for the JDBC 4.5 MR (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27693/head:pull/27693
$ git checkout pull/27693

Update a local copy of the PR:
$ git checkout pull/27693
$ git pull https://git.openjdk.org/jdk.git pull/27693/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27693

View PR using the GUI difftool:
$ git pr show -t 27693

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27693.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2025

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369432: Add Support for JDBC 4.5 MR

Reviewed-by: alanb, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 462 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@LanceAndersen The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 8, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2025

@LanceAndersen
Copy link
Contributor Author

/csr needed

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@LanceAndersen has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@LanceAndersen please create a CSR request for issue JDK-8369432 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@jdlib
Copy link

jdlib commented Oct 13, 2025

@LanceAndersen I could not find the JDBC 4.5 MR specification (e.g. at https://jcp.org/en/jsr/detail?id=221), can you provide a link?

@LanceAndersen
Copy link
Contributor Author

@LanceAndersen I could not find the JDBC 4.5 MR specification (e.g. at https://jcp.org/en/jsr/detail?id=221), can you provide a link?

The change log will be posted once the CSR has been approved for javadoc changes for the API

@LanceAndersen
Copy link
Contributor Author

LanceAndersen commented Oct 15, 2025 via email

@eirbjo
Copy link
Contributor

eirbjo commented Oct 15, 2025

Pattern::matches invokes Pattern::compile and String::matches invokes Pattern::matches so did not see the benefit when we added the methods originally in JDK 9

Yeah, it just seemed String:matches would be less verbose. I then noticed Roger raising related suggestions about precomplication, which is why I removed my comment from the PR since it seemed no longer relevant.

@LanceAndersen
Copy link
Contributor Author

Pattern::matches invokes Pattern::compile and String::matches invokes Pattern::matches so did not see the benefit when we added the methods originally in JDK 9

Yeah, it just seemed String:matches would be less verbose. I then noticed Roger raising related suggestions about precomplication, which is why I removed my comment from the PR since it seemed no longer relevant.

Ah that explains why I did not see your comment...

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Oct 17, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 17, 2025
* </UL>
* </UL>
*
* <h3>{@code java.sql} and {@code javax.sql} Features Introduced in the JDBC 4.5 API</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is consistent with the other updates but I'm wondering why it hasn't been switched to "module java.sql".

@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed csr Pull request needs approved CSR before integration labels Nov 5, 2025
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I through went several iterations of the API docs with Lance, all good there. I have not reviewed SQLUtils or the tests.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

9 participants