-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8369432: Add Support for JDBC 4.5 MR #27693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back lancea! A progress list of the required criteria for merging this PR into |
|
@LanceAndersen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 462 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@LanceAndersen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
/csr needed |
|
@LanceAndersen has indicated that a compatibility and specification (CSR) request is needed for this pull request. @LanceAndersen please create a CSR request for issue JDK-8369432 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
@LanceAndersen I could not find the JDBC 4.5 MR specification (e.g. at https://jcp.org/en/jsr/detail?id=221), can you provide a link? |
The change log will be posted once the CSR has been approved for javadoc changes for the API |
…ared default methods
|
On Oct 15, 2025, at 7:14 AM, Eirik Bjorsnos ***@***.***> wrote:
@eirbjo commented on this pull request.
In src/java.sql/share/classes/java/sql/Connection.java <#27693 (comment)>:
> + * @param alwaysQuote indicates if a simple SQL identifier should be
+ * returned as a quoted identifier
+ * @return A simple SQL identifier or a delimited identifier
+ * @throws SQLException if identifier is not a valid identifier
+ * @throws SQLFeatureNotSupportedException if the datasource does not support
+ * delimited identifiers
+ * @throws NullPointerException if identifier is ***@***.*** null}
+ *
+ * @SInCE 26
+ */
+ default String enquoteIdentifier(String identifier, boolean alwaysQuote) throws SQLException {
+ int len = identifier.length();
+ if (len < 1 || len > 128) {
+ throw new SQLException("Invalid name");
+ }
+ if (Pattern.compile("[\\p{Alpha}][\\p{Alnum}_]*").matcher(identifier).matches()) {
Did you consider using String::matches or Pattern:matches here and elsewhere instead of explicit compilation?
Pattern::matches invokes Pattern::compile and String::matches invokes Pattern::matches so did not see the benefit when we added the methods originally in JDK 9
|
Yeah, it just seemed |
Ah that explains why I did not see your comment... |
RogerRiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
| * </UL> | ||
| * </UL> | ||
| * | ||
| * <h3>{@code java.sql} and {@code javax.sql} Features Introduced in the JDBC 4.5 API</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is consistent with the other updates but I'm wondering why it hasn't been switched to "module java.sql".
AlanBateman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I through went several iterations of the API docs with Lance, all good there. I have not reviewed SQLUtils or the tests.
This PR adds support for the upcoming JDBC 4.5 MR which provides the following updates to the JDBC specification:
Tiers 1-3 have been run
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27693/head:pull/27693$ git checkout pull/27693Update a local copy of the PR:
$ git checkout pull/27693$ git pull https://git.openjdk.org/jdk.git pull/27693/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27693View PR using the GUI difftool:
$ git pr show -t 27693Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27693.diff
Using Webrev
Link to Webrev Comment