8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE #27766

fandreuz · 2025-10-13T11:26:36Z

In this PR I add a check to prevent debug builds to crash when an agent tries to attach while the JVM is not in live phase.

Passes tier1 and tier2 (fastdebug).

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE (Bug - P3)

Reviewers

Leonid Mesnik (@lmesnik - Reviewer)
Alex Menkov (@alexmenkov - Reviewer) Review applies to ba3dc024
Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27766/head:pull/27766
$ git checkout pull/27766

Update a local copy of the PR:
$ git checkout pull/27766
$ git pull https://git.openjdk.org/jdk.git pull/27766/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27766

View PR using the GUI difftool:
$ git pr show -t 27766

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27766.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-10-13T11:27:59Z

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-13T11:29:10Z

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE

Reviewed-by: lmesnik, sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

45e145f: 8359057: AbstractInterpreter::is_not_reached returns incorrectly with invokedynamic
4377e7c: 8367008: Algorithm identifiers for HmacSHA* should always have NULL as params
d8ebe38: 8370377: Avoid resolving constant pool entries during preimage generation in the training run
... and 10 more: https://git.openjdk.org/jdk/compare/27c83c730d8b0f87bb51230c35e4fe261c9d2723...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @lmesnik, @alexmenkov, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-10-13T11:30:06Z

@fandreuz The following labels will be automatically applied to this pull request:

hotspot
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

src/hotspot/share/prims/jvmtiAgentList.cpp

mlbridge · 2025-10-14T08:12:44Z

Webrevs

dholmes-ora

Generally looks good. Not 100% sure on the test structure but serviceability folk can chime in there if needed.

Suggestion:

diff --git a/src/jdk.jcmd/share/man/jcmd.md b/src/jdk.jcmd/share/man/jcmd.md
index 4e67e7a4502..69784050984 100644
--- a/src/jdk.jcmd/share/man/jcmd.md
+++ b/src/jdk.jcmd/share/man/jcmd.md
@@ -551,7 +551,7 @@ ## Commands for jcmd
     events, use `JFR.view all-events`.
 
 `JVMTI.agent_load` \[*arguments*\]
-:   Loads JVMTI native agent.
+:   Loads JVMTI native agent. (Live phase only)
 
     Impact: Low

src/hotspot/share/prims/jvmtiAgentList.cpp

test/hotspot/jtreg/serviceability/EarlyDynamicLoad/TestEarlyDynamicLoadJcmd.java

Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>

test/hotspot/jtreg/serviceability/EarlyDynamicLoad/TestEarlyDynamicLoadAttach.java

test/hotspot/jtreg/serviceability/EarlyDynamicLoad/libEarlyDynamicLoad.c

sspitsyn · 2025-10-16T22:31:57Z

The approach looks okay to me. Thank you for taking care about this issue!

sspitsyn

The fix is good. I've posted a couple of nits though.

test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/libEarlyDynamicLoad.cpp

test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/TestEarlyDynamicLoad.java

fandreuz · 2025-10-22T21:41:25Z

Thanks for the review @sspitsyn, @sspitsyn, @alexmenkov and @dholmes-ora.

sspitsyn · 2025-10-22T21:41:27Z

/sponsor

fandreuz · 2025-10-22T21:41:29Z

/integrate

openjdk · 2025-10-22T21:42:32Z

@sspitsyn The change author (@fandreuz) must issue an integrate command before the integration can be sponsored.

openjdk · 2025-10-22T21:42:55Z

@fandreuz
Your change (at version 1dafec3) is now ready to be sponsored by a Committer.

sspitsyn · 2025-10-22T21:43:05Z

Thank you for the updates!

sspitsyn · 2025-10-22T21:46:29Z

/sponsor

openjdk · 2025-10-22T21:47:07Z

Going to push as commit 2a8cbd9.
Since your change was applied there have been 13 commits pushed to the master branch:

45e145f: 8359057: AbstractInterpreter::is_not_reached returns incorrectly with invokedynamic
4377e7c: 8367008: Algorithm identifiers for HmacSHA* should always have NULL as params
d8ebe38: 8370377: Avoid resolving constant pool entries during preimage generation in the training run
... and 10 more: https://git.openjdk.org/jdk/compare/27c83c730d8b0f87bb51230c35e4fe261c9d2723...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-10-22T21:47:20Z

@sspitsyn @fandreuz Pushed as commit 2a8cbd9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

fandreuz · 2025-10-27T08:34:26Z

/backport jdk25u

openjdk · 2025-10-27T08:36:19Z

@fandreuz the backport was successfully created on the branch backport-fandreuz-2a8cbd94-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2a8cbd94 from the openjdk/jdk repository.

The commit being backported was authored by Francesco Andreuzzi on 22 Oct 2025 and was reviewed by Leonid Mesnik, Serguei Spitsyn and Alex Menkov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u:

$ git fetch https://github.com/openjdk-bots/jdk25u.git backport-fandreuz-2a8cbd94-master:backport-fandreuz-2a8cbd94-master
$ git checkout backport-fandreuz-2a8cbd94-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u.git backport-fandreuz-2a8cbd94-master

fandreuz added 2 commits October 13, 2025 11:25

fix and test

b7166c7

nl

29f1a25

openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Oct 13, 2025

krk reviewed Oct 13, 2025

View reviewed changes

src/hotspot/share/prims/jvmtiAgentList.cpp Show resolved Hide resolved

cc

b821ba3

fandreuz force-pushed the JDK-8359472 branch from 65df039 to b821ba3 Compare October 13, 2025 14:37

fandreuz added 5 commits October 13, 2025 15:48

macro

001e2f6

fix check

96e2340

mv

cdd5a22

nn

e3df527

mv

941f9a6

fandreuz marked this pull request as ready for review October 14, 2025 08:07

openjdk bot added the rfr Pull request is ready for review label Oct 14, 2025

summary

49722e1

dholmes-ora suggested changes Oct 16, 2025

View reviewed changes

fandreuz and others added 5 commits October 16, 2025 11:24

Update src/hotspot/share/prims/jvmtiAgentList.cpp

84f168b

Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>

nn

2e21bc3

errno

e9646e6

ops

cbbbf8a

debug

b53c2da

lmesnik suggested changes Oct 16, 2025

View reviewed changes

test/hotspot/jtreg/serviceability/EarlyDynamicLoad/TestEarlyDynamicLoadAttach.java Outdated Show resolved Hide resolved

test/hotspot/jtreg/serviceability/EarlyDynamicLoad/libEarlyDynamicLoad.c Outdated Show resolved Hide resolved

fandreuz added 2 commits October 16, 2025 20:47

replace

2a7ab98

revert

7870ca7

check jcmd exist

1363424

fandreuz added 3 commits October 21, 2025 09:26

jvmti errors

925f9fc

empty stderr

60d6fdf

cc

ba3dc02

alexmenkov approved these changes Oct 21, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2025

sspitsyn approved these changes Oct 21, 2025

View reviewed changes

test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/libEarlyDynamicLoad.cpp Show resolved Hide resolved

test/hotspot/jtreg/serviceability/attach/EarlyDynamicLoad/TestEarlyDynamicLoad.java Outdated Show resolved Hide resolved

fandreuz added 3 commits October 22, 2025 08:28

return value

2059679

Merge branch 'master' into JDK-8359472

462f982

rename

1dafec3

openjdk bot removed the ready Pull request is ready to be integrated label Oct 22, 2025

sspitsyn approved these changes Oct 22, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2025

lmesnik approved these changes Oct 22, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 22, 2025

openjdk bot added the integrated Pull request has been integrated label Oct 22, 2025

openjdk bot closed this Oct 22, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 22, 2025

Uh oh!

8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE #27766

8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE #27766

Conversation

fandreuz commented Oct 13, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 13, 2025

Uh oh!

openjdk bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mlbridge bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

dholmes-ora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sspitsyn commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sspitsyn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fandreuz commented Oct 22, 2025

Uh oh!

sspitsyn commented Oct 22, 2025

Uh oh!

fandreuz commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025

Uh oh!

sspitsyn commented Oct 22, 2025

Uh oh!

sspitsyn commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025

Uh oh!

openjdk bot commented Oct 22, 2025

Uh oh!

fandreuz commented Oct 27, 2025

Uh oh!

openjdk bot commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

fandreuz commented Oct 13, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 13, 2025 •

edited

Loading

openjdk bot commented Oct 13, 2025 •

edited

Loading

mlbridge bot commented Oct 14, 2025 •

edited

Loading

sspitsyn commented Oct 16, 2025 •

edited

Loading