8364583: ColorConvertOp fails for CMYK → RGB conversion #27785

prrace · 2025-10-14T05:25:44Z

color is initially returned as 4 element array but we over-write with 3 element and so next time through the loop it is used by but is too short.
More details in JBS.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8364583: ColorConvertOp fails for CMYK → RGB conversion (Bug - P4)

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)
Prasanta Sadhukhan (@prsadhuk - Reviewer)
Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27785/head:pull/27785
$ git checkout pull/27785

Update a local copy of the PR:
$ git checkout pull/27785
$ git pull https://git.openjdk.org/jdk.git pull/27785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27785

View PR using the GUI difftool:
$ git pr show -t 27785

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27785.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-10-14T05:27:36Z

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-14T05:28:31Z

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364583: ColorConvertOp fails for CMYK → RGB conversion

Reviewed-by: serb, psadhukhan, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 348 new commits pushed to the master branch:

3250823: 8364361: [process] java.lang.Process should implement Closeable
0555f62: 8371094: --mac-signing-key-user-name no longer works
8224292: 8365069: Refactor tests to use PEM API (Phase 1)
... and 345 more: https://git.openjdk.org/jdk/compare/4ca4485e9af10a49ca95710c4e26aa3895835d47...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-14T05:29:16Z

@prrace The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-10-14T05:32:17Z

Webrevs

00: Full (6c2a90eb)

mrserb · 2025-10-16T17:37:20Z

src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java

                for (int x = 0; x < w; x++) {
                    pixel = srcRas.getDataElements(x, y, pixel);
-                    color = srcCM.getNormalizedComponents(pixel, color, 0);
+                    color = srcCM.getNormalizedComponents(pixel, null, 0);


Since this is executed for each pixel, it will generate garbage equal to the image size. Maybe we can cleanly split the usage of the two vars here? Note that the bug only occurs when the source image does not use an ICC profile, but this change would increase garbage for both ICC and non-ICC profiles.

You mean keep the original returned float[] color separate from the one that's later over-written.
I'd thought about that but I don't think it is worth it.
It can also be over-written at line 835. There's just too much state tracking needed to save
the GC a tiny bit of effort freeing small transient objects.
Also it already is re-initialised for each scanline. See line 807, so it isn't (quite) the same array for the entire image anyway.

It can also be over-written at line 835.

Interesting, is it possible that that line has the same bug?
color = dstColorSpace.fromCIEXYZ(dstColor);
Does dstColor always have the same number of components as CIEXYZ?

Is the logic of using CIEXYZ for mix of non-/ICC source and non-/ICC destination actually correct?

fromCIEXYZ is defined on ColorSpace, not ICC_ColorSpace.

It requires 3 (or more) components, and then dstColorSpace will return an array of colors in its own colorspace.
The dstColor parameter is always created with at least 3 components based on the dstNumComp
And if there's no bug in dstColorSpace it should return an array of the right length for itself.
So if there's a bug it isn't obvious to me.

Seems the destination handles it properly; I tested it with the following example:

import java.awt.Transparency; import java.awt.color.ColorSpace; import java.awt.image.BufferedImage; import java.awt.image.ColorConvertOp; import java.awt.image.ComponentColorModel; import java.awt.image.DataBuffer; import java.awt.image.WritableRaster; import static java.awt.color.ColorSpace.TYPE_2CLR; import static java.awt.color.ColorSpace.TYPE_FCLR; import static java.awt.color.ColorSpace.TYPE_GRAY; public final class TestCCP { private static final int WIDTH = 10; private static final int HEIGHT = 10; private static class CustomColorSpace extends ColorSpace { private final int numComponents; private CustomColorSpace(int type, int numComponents) { super(type, numComponents); this.numComponents = numComponents; } @Override public float[] toRGB(float[] colorvalue) { return new float[3]; } @Override public float[] fromRGB(float[] rgbvalue) { return new float[numComponents]; } @Override public float[] toCIEXYZ(float[] colorvalue) { return new float[3]; } @Override public float[] fromCIEXYZ(float[] colorvalue) { return new float[numComponents]; } } private static final ColorSpace[] CS = { ColorSpace.getInstance(ColorSpace.CS_CIEXYZ), ColorSpace.getInstance(ColorSpace.CS_GRAY), ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB), ColorSpace.getInstance(ColorSpace.CS_PYCC), ColorSpace.getInstance(ColorSpace.CS_sRGB), new CustomColorSpace(TYPE_GRAY, 1), new CustomColorSpace(TYPE_2CLR, 2), new CustomColorSpace(TYPE_FCLR, 15) }; public static void main(String[] args) { for (ColorSpace srcCS : CS) { for (ColorSpace fromCS : CS) { for (ColorSpace toCS : CS) { for (ColorSpace dstCS : CS) { BufferedImage src = createTestImage(srcCS); BufferedImage dst = createTestImage(dstCS); new ColorConvertOp(fromCS, toCS, null).filter(src, dst); } } } } } private static BufferedImage createTestImage(ColorSpace cs) { ComponentColorModel cm = new ComponentColorModel(cs, false, false, Transparency.OPAQUE, DataBuffer.TYPE_BYTE); WritableRaster raster = cm.createCompatibleWritableRaster(WIDTH, HEIGHT); return new BufferedImage(cm, raster, cm.isAlphaPremultiplied(), null); } }

@mrserb @prrace

Are we testing the else block - the one for "possible non-ICC src, possible CSList, possible non-ICC dst" with the test provided by Sergey?

Ln#872 in the else block has a similar line color = srcCM.getNormalizedComponents(spixel, color, 0); and the above test runs fine if normComponents is set to either color or null.

prrace · 2025-11-02T17:28:50Z

@prsadhuk @honkar-jdk please review

honkar-jdk · 2025-11-04T01:01:30Z

In the process of reviewing the PR

prsadhuk · 2025-11-04T12:21:33Z

test/jdk/java/awt/image/ColorConvertOp/ColorConvertOpCMYK.java

+        ColorModel sourceModel = source.getColorModel();
+        ColorSpace cs = ColorSpace.getInstance(ColorSpace.CS_sRGB);
+        ColorConvertOp convertOp = new ColorConvertOp(cs, null);
+        BufferedImage rgb = convertOp.filter(source, null);


rgb variable can be removed...

honkar-jdk

The fix LGTM for the case demonstrated by the regression test although I'm not clear on the case described by @mrserb in this thread - https://github.com/openjdk/jdk/pull/27785/files#r2487547644

prrace · 2025-11-04T21:38:49Z

/integrate

openjdk · 2025-11-04T21:40:56Z

Going to push as commit 8585b46.
Since your change was applied there have been 348 commits pushed to the master branch:

3250823: 8364361: [process] java.lang.Process should implement Closeable
0555f62: 8371094: --mac-signing-key-user-name no longer works
8224292: 8365069: Refactor tests to use PEM API (Phase 1)
... and 345 more: https://git.openjdk.org/jdk/compare/4ca4485e9af10a49ca95710c4e26aa3895835d47...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-11-04T21:41:11Z

@prrace Pushed as commit 8585b46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8364583

6c2a90e

openjdk bot changed the title ~~8364583~~ 8364583: ColorConvertOp fails for CMYK → RGB conversion Oct 14, 2025

openjdk bot added the client client-libs-dev@openjdk.org label Oct 14, 2025

openjdk bot added the rfr Pull request is ready for review label Oct 14, 2025

mrserb reviewed Oct 16, 2025

View reviewed changes

mrserb approved these changes Nov 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2025

prsadhuk reviewed Nov 4, 2025

View reviewed changes

prsadhuk approved these changes Nov 4, 2025

View reviewed changes

honkar-jdk approved these changes Nov 4, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Nov 4, 2025

openjdk bot closed this Nov 4, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2025

8364583: ColorConvertOp fails for CMYK → RGB conversion #27785

8364583: ColorConvertOp fails for CMYK → RGB conversion #27785

Conversation

prrace commented Oct 14, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 14, 2025

Uh oh!

openjdk bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 14, 2025

Uh oh!

mlbridge bot commented Oct 14, 2025

Webrevs

Uh oh!

mrserb Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

prrace Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrserb Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prrace Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

mrserb Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

prrace commented Nov 2, 2025

Uh oh!

honkar-jdk commented Nov 4, 2025

Uh oh!

prsadhuk Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

honkar-jdk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prrace commented Nov 4, 2025

Uh oh!

openjdk bot commented Nov 4, 2025

Uh oh!

openjdk bot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

prrace commented Oct 14, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 14, 2025 •

edited

Loading

prrace Oct 23, 2025 •

edited

Loading

mrserb Oct 24, 2025 •

edited

Loading

prsadhuk Nov 4, 2025 •

edited

Loading

honkar-jdk left a comment •

edited

Loading