8321687: Test vmTestbase/nsk/jvmti/scenarios/contention/TC03/tc03t002/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE

[lmesnik]

Test might fail with

----------System.out:(5/399)----------
The following fake exception stacktrace is for failure analysis.
nsk.share.Fake_Exception_for_RULE_Creation: (tc03t002.cpp:144) jvmti->GetCurrentContendedMonitor(threadList[pThread].thread, &monitor)
at nsk_lvcomplain(nsk_tools.cpp:172)
# ERROR: tc03t002.cpp, 144: jvmti->GetCurrentContendedMonitor(threadList[pThread].thread, &monitor)
# jvmti error: code=15, name=JVMTI_ERROR_THREAD_NOT_ALIVE

if some of threads unexpectedly finishes during test execution. 

It might happens only for some tests that are not started and verified by thread. So the fix is to skip them and verify only "Debugee" threads that might be in the deadlock.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321687: Test vmTestbase/nsk/jvmti/scenarios/contention/TC03/tc03t002/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE (Bug - P5)

Reviewers

• Chris Plummer (@plummercj - Reviewer) Review applies to 954fc280
• Serguei Spitsyn (@sspitsyn - Reviewer) Review applies to e70b8841
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27831/head:pull/27831
$ git checkout pull/27831

Update a local copy of the PR:
$ git checkout pull/27831
$ git pull https://git.openjdk.org/jdk.git pull/27831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27831

View PR using the GUI difftool:
$ git pr show -t 27831

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27831.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321687: Test vmTestbase/nsk/jvmti/scenarios/contention/TC03/tc03t002/TestDescription.java failed: JVMTI_ERROR_THREAD_NOT_ALIVE

Reviewed-by: amenkov, cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 0cc88e4: 8370028: Remove author tags from mathematical classes
• 6cd7f30: 8369742: Link AOT-linked classes at JVM bootstrap
• 0cb8ccd: 8369642: [ubsan] nmethod::nmethod null pointer passed as argument 2 to memcpy
• ... and 50 more: https://git.openjdk.org/jdk/compare/c9cbd31f8575a25c4decd68dc645378c5ba2bad0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (507b7e18)
• 05: Full - Incremental (954fc280)
• 04: Full - Incremental (4833e33b)
• 03: Full - Incremental (e70b8841)
• 02: Full - Incremental (80fc4d55)
• 01: Full - Incremental (385b3e00)
• 00: Full (7cf8f9ff)

[plummercj]

Isn't this also an issue for tc03t001?

[lmesnik]

Isn't this also an issue for tc03t001?

Thanks, I've updated this test also.

[sspitsyn]

This does not follow the same pattern as in tc03t002.cpp.
The variable debuggee_thread_cnt is not correctly set and used.

[lmesnik]

Thanks! Corrected.

[sspitsyn]

Thank you for update. Looks good.

[alexmenkov]

The fix looks incomplete.
There is global threads_count variable and it's used in a number of places in the file.
I think it would be simpler to add local total_thread_count and use it only to initialize threadList (GetAllThreads, allocate threadList, iteration through threads); debuggee_thread_cnt needs to be replaced with threads_count

[lmesnik]

Thank you! You are correct, the debuggee_thread_cnt is made global and used while printing locks.
I also renamed it to debuggee_threads_cnt

[alexmenkov]

There are still some wrong usage thread_count instead of debuggee_threads_cnt

[lmesnik]

There are still some wrong usage thread_count instead of debuggee_threads_cnt
Thanks, I applied your changes and tested them.

[lmesnik]

/integrate

[openjdk]

Going to push as commit 1816570.
Since your change was applied there have been 55 commits pushed to the master branch:

• 926f61f: 8369447: GenShen: Regulator thread may observe inconsistent states
• 49b17dd: 8356575: Test order in which jpackage fills app image
• 0cc88e4: 8370028: Remove author tags from mathematical classes
• ... and 52 more: https://git.openjdk.org/jdk/compare/c9cbd31f8575a25c4decd68dc645378c5ba2bad0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 1816570.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.