Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 19, 2025

This patch adds missing @Override annotations to methods in the com.sun.beans package that override superclass or interface methods.
Only source annotations are added; there are no behavioral changes.

Unlike the previous patches, I have skipped adding the final to classes, since it should be done carefully when applied to shared code. So I do not want to mix it with other changes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370197: Add missing @Override annotations in com.sun.beans package (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27887/head:pull/27887
$ git checkout pull/27887

Update a local copy of the PR:
$ git checkout pull/27887
$ git pull https://git.openjdk.org/jdk.git pull/27887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27887

View PR using the GUI difftool:
$ git pr show -t 27887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27887.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 19, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370197: Add missing @Override annotations in com.sun.beans package

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 19, 2025
@openjdk
Copy link

openjdk bot commented Oct 19, 2025

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review October 20, 2025 02:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2025
@mrserb
Copy link
Member Author

mrserb commented Oct 26, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2025

Going to push as commit e7c7892.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2025
@openjdk openjdk bot closed this Oct 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2025
@openjdk
Copy link

openjdk bot commented Oct 26, 2025

@mrserb Pushed as commit e7c7892.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants