-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8370197: Add missing @Override annotations in com.sun.beans package #27887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
|
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
/integrate |
|
Going to push as commit e7c7892. |
This patch adds missing
@Overrideannotations to methods in thecom.sun.beanspackage that override superclass or interface methods.Only source annotations are added; there are no behavioral changes.
Unlike the previous patches, I have skipped adding the
finalto classes, since it should be done carefully when applied to shared code. So I do not want to mix it with other changes.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27887/head:pull/27887$ git checkout pull/27887Update a local copy of the PR:
$ git checkout pull/27887$ git pull https://git.openjdk.org/jdk.git pull/27887/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27887View PR using the GUI difftool:
$ git pr show -t 27887Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27887.diff
Using Webrev
Link to Webrev Comment