8346944: Update Unicode Data Files to 17.0.0 #28093

naotoj · 2025-10-31T20:53:16Z

Updates the JDK to use the latest Unicode 17.0.0, which also updates the ICU4J along with it (8346947
Update ICU4J to Version 78.1). The corresponding CSR has already been approved.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8367272 to be approved

Warnings

⚠️ Patch contains a binary file (src/java.base/share/classes/jdk/internal/icu/impl/data/icudata/nfc.nrm)
⚠️ Patch contains a binary file (src/java.base/share/classes/jdk/internal/icu/impl/data/icudata/ubidi.icu)
⚠️ Patch contains a binary file (src/java.base/share/classes/jdk/internal/icu/impl/data/icudata/uprops.icu)

Issues

JDK-8346944: Update Unicode Data Files to 17.0.0 (Enhancement - P3)
JDK-8346947: Update ICU4J to Version 78.1 (Enhancement - P4)
JDK-8367272: Update Unicode Data Files to 17.0.0 (CSR)

Reviewers

Joe Wang (@JoeWang-Java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28093/head:pull/28093
$ git checkout pull/28093

Update a local copy of the PR:
$ git checkout pull/28093
$ git pull https://git.openjdk.org/jdk.git pull/28093/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28093

View PR using the GUI difftool:
$ git pr show -t 28093

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28093.diff

Using Webrev

Link to Webrev Comment

naotoj · 2025-10-31T20:53:49Z

/issue add JDK-8346947

bridgekeeper · 2025-10-31T20:54:43Z

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-10-31T20:55:53Z

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346944: Update Unicode Data Files to 17.0.0
8346947: Update ICU4J to Version 78.1

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

695a4ab: 8371966: RISC-V: Incorrect pointer dereference in TemplateInterpreterGenerator::generate_native_entry
46b5e58: 8371697: test/jdk/java/nio/file/FileStore/Basic.java fails after 8360887 on linux
6968216: 8293484: AArch64: TestUseSHA512IntrinsicsOptionOnSupportedCPU.java fails on CPU with SHA512 feature support
... and 3 more: https://git.openjdk.org/jdk/compare/9ec773ad27773f5813c79ae33ac1d2393c2e0cc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-10-31T20:56:47Z

@naotoj
Adding additional issue to issue list: 8346947: Update ICU4J to Version 78.1.

openjdk · 2025-10-31T20:57:35Z

@naotoj The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-11-13T22:05:53Z

Webrevs

01: Full - Incremental (088cdaea)
00: Full (d9cff00a)

JoeWang-Java

LGTM.

JoeWang-Java · 2025-11-18T05:08:10Z

src/java.base/share/classes/jdk/internal/icu/util/VersionInfo.java

     */
    @Deprecated
-    public static final String ICU_DATA_VERSION_PATH = "76b";
+    public static final String ICU_DATA_VERSION_PATH = "78b";


Now with fixed path "icudata", this seems to be no longer used.

Correct. The change was in the upstream which was just merged to our codebase: unicode-org/icu@d93b8bb#diff-2d49053b635edae3d63d88a8b058994e7b156a50d5056ac0fb3bbfe5daa7c4e4L242

naotoj · 2025-11-18T18:32:30Z

Thanks for the review!
/integrate

openjdk · 2025-11-18T18:35:06Z

Going to push as commit 4a97563.
Since your change was applied there have been 26 commits pushed to the master branch:

b3e408c: 8372045: AOT assembly phase asserts with old class if AOT class linking is disabled
0e6c7e8: 8371896: Links in snippets can not be highlighted
ac6f5e9: 8366094: Sealed graph for nested types creates broken links
... and 23 more: https://git.openjdk.org/jdk/compare/9ec773ad27773f5813c79ae33ac1d2393c2e0cc8...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-11-18T18:35:18Z

@naotoj Pushed as commit 4a97563.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

justin-curtis-lu

lgtm. (Looks like I missed integration by a few minutes; perhaps my comment can go into Unicode 18)

justin-curtis-lu · 2025-11-18T18:35:07Z

src/java.base/share/classes/java/lang/Character.java

     */
    public static final class UnicodeBlock extends Subset {
        /**
         * NUM_ENTITIES should match the total number of UnicodeBlocks.


I thought at first NUM_ENTITIES should be 790 due to 8 new UnicodeBlocks being added. However, it does go up to 804, becasue the total number includes the identifiers and aliases (which is still a single UnicodeBlock). I think that distinction is worth correcting in the comment.

Good point. Filed: https://bugs.openjdk.org/browse/JDK-8372117

openjdk bot added the csr Pull request needs approved CSR before integration label Oct 31, 2025

openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Oct 31, 2025

openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 11, 2025

naotoj added 10 commits November 12, 2025 12:50

initial commit

c754aa9

17-beta

3ca6661

icudt78b

4a795ec

CaseFolding.text -> 17, copyright symbol as is

92062f6

icudata78b(binary)

1061f39

17.0 final

992d2a2

.md file changes

091608f

icu4j final

ff40292

Update versions

daae3c4

icudata path fix

d9cff00

naotoj force-pushed the JDK-8346944-Unicode-17 branch from e1a9e29 to d9cff00 Compare November 12, 2025 20:50

naotoj marked this pull request as ready for review November 13, 2025 22:00

openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025

Merge branch 'master' into JDK-8346944-Unicode-17

088cdae

JoeWang-Java approved these changes Nov 18, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2025

openjdk bot added the integrated Pull request has been integrated label Nov 18, 2025

openjdk bot closed this Nov 18, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2025

justin-curtis-lu reviewed Nov 18, 2025

View reviewed changes

8346944: Update Unicode Data Files to 17.0.0 #28093

8346944: Update Unicode Data Files to 17.0.0 #28093

Uh oh!

Conversation

naotoj commented Oct 31, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Warnings

Issues

Reviewers

Reviewing

Uh oh!

naotoj commented Oct 31, 2025

Uh oh!

bridgekeeper bot commented Oct 31, 2025

Uh oh!

openjdk bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 31, 2025

Uh oh!

openjdk bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

JoeWang-Java left a comment

Choose a reason for hiding this comment

Uh oh!

JoeWang-Java Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj commented Nov 18, 2025

Uh oh!

openjdk bot commented Nov 18, 2025

Uh oh!

openjdk bot commented Nov 18, 2025

Uh oh!

justin-curtis-lu left a comment

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

naotoj commented Oct 31, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Oct 31, 2025 •

edited

Loading

openjdk bot commented Oct 31, 2025 •

edited

Loading

mlbridge bot commented Nov 13, 2025 •

edited

Loading