8371141: Shenandoah: Many test timeouts with -XX:-UseTLAB

[kdnilsen]

Problem list no-tlab versions of tests that fail after integration of #26867

We expect the small regression (increase) in time spent holding the global heap log will be counterbalanced by resolution of https://bugs.openjdk.org/browse/JDK-8361099, which performs shared (no-tlab) allocations without acquiring the global heap lock.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371141: Shenandoah: Many test timeouts with -XX:-UseTLAB (Bug - P4)

Reviewers

• Xiaolong Peng (@pengxiaolong - Committer)
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)
• William Kemper (@earthling-amzn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28133/head:pull/28133
$ git checkout pull/28133

Update a local copy of the PR:
$ git checkout pull/28133
$ git pull https://git.openjdk.org/jdk.git pull/28133/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28133

View PR using the GUI difftool:
$ git pr show -t 28133

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28133.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371141: Shenandoah: Many test timeouts with -XX:-UseTLAB

Reviewed-by: xpeng, ysr, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 4c6af03: 8337142: StackOverflowError in Types.containsTypeRecursive with deeply nested type hierarchy
• 2f455ed: 8371092: NullPointerException in AltServiceUsageTest.afterClass() test
• 7d3c66f: 8371114: Problemlist vmTestbase/nsk/jvmti/scenarios/events/EM02/em02t006/TestDescription.java
• ... and 2 more: https://git.openjdk.org/jdk/compare/d4622b2ceac6b6aef2717bf427878df1290c4a38...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kdnilsen To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[pengxiaolong]

Looks good to me, I'll test and revert this after the CAS allocator PR.

[ysramakrishna]

/label add hotspot-gc

[openjdk]

@ysramakrishna
The hotspot-gc label was successfully added.

[ysramakrishna]

/label add hotspot-gc

/cc hotspot-gc

[openjdk]

@ysramakrishna The hotspot-gc label was already applied.

[openjdk]

@ysramakrishna The hotspot-gc label was already applied.

[mlbridge]

Webrevs

• 00: Full (4d46e86f)

[kdnilsen]

/integrate

[openjdk]

Going to push as commit 87c2091.
Since your change was applied there have been 15 commits pushed to the master branch:

• c6a8815: 8369238: Allow virtual thread preemption on some common class initialization paths
• c8f5fd6: 8371184: Improve jpackage test coverage for "--app-image" option
• 463f5dc: 8371296: Refactor tests to use PEM API (Phase 1) - Fix WriteP12Test failure
• ... and 12 more: https://git.openjdk.org/jdk/compare/d4622b2ceac6b6aef2717bf427878df1290c4a38...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kdnilsen Pushed as commit 87c2091.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.