Skip to content

8371297: C2: assert triggered in BoolTest::BoolTest #28141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

8371297: C2: assert triggered in BoolTest::BoolTest #28141

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e27247b
initial commit
Sep 12, 2025
4a75e87
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 12, 2025
4ee1df1
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 15, 2025
0ff5e42
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 18, 2025
924c4c9
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 22, 2025
75dee02
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 25, 2025
57973f4
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 25, 2025
4b058ce
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 29, 2025
b73a502
Merge branch 'openjdk:master' into master
Hamlin-Li Sep 30, 2025
8eba0c0
Merge branch 'openjdk:master' into master
Hamlin-Li Oct 1, 2025
7f36f23
Merge branch 'openjdk:master' into master
Hamlin-Li Oct 13, 2025
3089ec9
Merge branch 'openjdk:master' into master
Hamlin-Li Oct 14, 2025
2238d76
Merge branch 'openjdk:master' into master
Hamlin-Li Oct 16, 2025
c0358cf
Merge branch 'openjdk:master' into master
Hamlin-Li Oct 20, 2025
f54562f
Merge branch 'openjdk:master' into master
Hamlin-Li Oct 29, 2025
6635678
Merge branch 'openjdk:master' into master
Hamlin-Li Nov 3, 2025
736425c
Merge branch 'openjdk:master' into master
Hamlin-Li Nov 4, 2025
0c877e2
initial commit
Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/hotspot/share/opto/vtransform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1421,8 +1421,9 @@ void VTransformReinterpretVectorNode::print_spec() const {

void VTransformBoolVectorNode::print_spec() const {
VTransformVectorNode::print_spec();
const BoolTest bt(_test._mask);
tty->print(" test=");
BoolTest::mask m = BoolTest::mask(_test._mask & ~BoolTest::unsigned_compare);
const BoolTest bt(m);
tty->print(" test=%s", m == _test._mask ? "" : "unsigned ");
bt.dump_on(tty);
Copy link
Member

@dean-long dean-long Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why we pass the raw mask around instead of keeping it encapsulated in a BoolTest object. Elsewhere I saw code like this:
cond->get_con() & (BoolTest::unsigned_compare - 1)
which seems to be making fragile assumptions about BoolTest internals.

Copy link
Author

@Hamlin-Li Hamlin-Li Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dean-long Yes, I have the same feeling that BoolTest is currently used in a fragile way. The reasons could be, BoolTest itself is by design a struct and expose all its status, and unsigned_compare is indeed not formally supported but needed somewhere e.g. in vector intrinsic, and auto-vectorization (after #28047).
I think it's worth to do more investigation about the refactoring of BoolTest. Besides of several places using unsigned_compare, there are more places using signed BoolTest, it might be helpful to do it in another specific pr, so file https://bugs.openjdk.org/browse/JDK-8371396 to track it, feel free to take it if you already have a solution or idea.

This issue (in fact it's #27942) blocks several other prs in my backlog for a while, e.g. #25336, #25341. It helps to resolve this assert in a quick (although ugly) way. Please kindly let me know how you think about it. Thanks!

}
#endif