Skip to content

Conversation

@YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Nov 17, 2025

Microsoft has been published Visual Studio 2026, and it can build OpenJDK for Windows without any code changes if we add it to build toolchain.

Now we should support new Visual Studio for maintainability.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371967: Add Visual Studio 2026 to build toolchain for Windows (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28342/head:pull/28342
$ git checkout pull/28342

Update a local copy of the PR:
$ git checkout pull/28342
$ git pull https://git.openjdk.org/jdk.git pull/28342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28342

View PR using the GUI difftool:
$ git pr show -t 28342

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28342.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2025

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371967: Add Visual Studio 2026 to build toolchain for Windows

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 17, 2025
@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@YaSuenag The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2025

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as it works. I don't have the ability to verify myself so will have to take your word for it.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2025
@YaSuenag
Copy link
Member Author

Thanks @erikj79 for your review!
I tested this change with VS 2026 Community Edition on WSL1 (Fedora 42) on Windows 11 25H2.

@YaSuenag
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2025

Going to push as commit dcba014.
Since your change was applied there have been 35 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2025
@openjdk openjdk bot closed this Nov 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2025
@openjdk
Copy link

openjdk bot commented Nov 18, 2025

@YaSuenag Pushed as commit dcba014.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@YaSuenag YaSuenag deleted the vs2026 branch November 18, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants